Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forsaken being spawned now swaps all groundside resin to forsaken hive. #3630

Closed
wants to merge 4 commits into from
Closed

Forsaken being spawned now swaps all groundside resin to forsaken hive. #3630

wants to merge 4 commits into from

Conversation

NewyearnewmeUwu
Copy link
Contributor

@NewyearnewmeUwu NewyearnewmeUwu commented Jun 14, 2023

About the pull request

Forsaken are being slowed down by normal xeno hive weeds and killed by the normal hive's groundside acid traps. This fixes that. It also deletes normal hive groundside acid pillars as a TEMPORARY WORKAROUND because they will delete forsaken weeds even when swapped to forsaken hive.

Explain why it's good for the game

This was requested by Morrow, and it works.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Forsaken being spawned now swaps all groundside resin to forsaken hive.
/:cl:

@NewyearnewmeUwu NewyearnewmeUwu marked this pull request as ready for review June 14, 2023 19:52
@github-actions github-actions bot added the Feature Feature coder badge label Jun 14, 2023
Co-authored-by: fira <loyauflorian@gmail.com>
@ihatethisengine
Copy link
Contributor

I am not sure if it should change all the weeds. Yesterday we had a really fun round, when I was playing forsaken and two xenos from regular sky came back on a pod. It was a tense fight, partly because they still had their walls, sticky and weeds.

@ghost ghost marked this pull request as draft June 16, 2023 20:56
@NewyearnewmeUwu NewyearnewmeUwu marked this pull request as ready for review June 17, 2023 18:55
@Segrain
Copy link
Contributor

Segrain commented Jun 19, 2023

This should happen after the dropship takeoff and it should skip the weeds on the dropship itself.
Frankly, much simpler solution would be to simply hardcode regular and forsaken hive as allies. Even should a regular xeno somehow end back on the planet, why should they be hostile to each other?

@ghost
Copy link

ghost commented Jun 19, 2023

TFW I did actually grief your PR 🤯

I'm fine with just setting forsaken as friendly. Sometimes the XvX is fun for people which is why we're jumping through hoops a bit. Happy either way 🤷

@ghost ghost marked this pull request as draft June 19, 2023 18:08
github-merge-queue bot pushed a commit that referenced this pull request Jul 5, 2023
# About the pull request

This PR makes groundside xeno structures and weeds become forsaken after
hijack.

With blessing, finishing this up for the author of this:
#3630

# Explain why it's good for the game

It is annoying to try and fight through all traps and such to go and do
stuff as a forsaken xeno.

I would just hardcode ally but some people enjoy the XvX that sometimes
occurs.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog

:cl: Newyearnewme, Morrow
add: Xeno structures/weeds now become forsaken after hijack
/:cl:

---------

Co-authored-by: Asbestos Gremlin <etgcollege@gmail.com>
Co-authored-by: NewyearnewmeUwu <70115628+NewyearnewmeUwu@users.noreply.github.com>
Co-authored-by: fira <loyauflorian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants