Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-balances acid damage #3749

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Jun 27, 2023

About the pull request

Changes acid splash damage . it will now be reduced with BIO armor and it will escale depending on your xeno TIER .
formula = 20 + (TIERx5)

Reduces M3 light armor Bio resistance to be MEDIUMLOW instead of MEDIUM HIGH

Increases M3 Heavy armor Bio resistance to be MEDIUMHIGH instead of MEDIUM

Explain why it's good for the game

Acid blood has been changing numbers pretty frequently over the years i think the issue is that is often too high or too low so now it adjusts depending on your tier so higher castes cant be just killed with knifes winout come consequences.

Acid blood now applies armored damage . this is to encourage heavier armor to those that want to take less damage from this kind of encounters.

Light armor BIO resistance has been reduced . the reasoning being that is the fastest armor available it makes little to no sense that is the one that protects you the most of them ALL variations .

Heavy armor BIO resistance was increased for those that wish to have a tankier playstyle be less affected.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Acid Splash damage increased to 25
balance: Acid Splash damage can be reduced with BIO armor.
balance: Reduced Light armor BIO resistance by 10
balance: Increased Heavy armor BIO resistance by 5
balance: Increased VL vest BIO resistance by 5
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 27, 2023
@MusselMain
Copy link

does this apply to suicide runners

@Diegoflores31
Copy link
Contributor Author

does this apply to suicide runners

no this is exclusively for acid splash ( the damage you get for shooting xenos too near)

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, willing to TM and try after changes.

code/modules/clothing/suits/marine_armor.dm Outdated Show resolved Hide resolved
@morrowwolf morrowwolf marked this pull request as draft June 28, 2023 05:35
@harryob harryob changed the title The acid.... Re-balances acid damage Jun 28, 2023
@Diegoflores31 Diegoflores31 marked this pull request as ready for review June 28, 2023 22:43
@Diegoflores31
Copy link
Contributor Author

suggestions applied :3

@harryob harryob added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jun 30, 2023
@Drulikar Drulikar added the Needs Testing Need to test it on the guinea pigs (production server) label Jul 6, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about it, I don't think the tiered acid damage is really great and this is overall a nerf to acid damage in its current state.

Let's remove the tiered change and up the base acid blood damage by 5 and give it a whirl.

@morrowwolf morrowwolf marked this pull request as draft July 11, 2023 01:55
@Diegoflores31 Diegoflores31 marked this pull request as ready for review July 13, 2023 21:18
@Diegoflores31 Diegoflores31 requested a review from morrowwolf July 13, 2023 21:20
@morrowwolf morrowwolf added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit 6ce2638 Jul 19, 2023
cm13-github added a commit that referenced this pull request Jul 19, 2023
github-actions bot added a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants