Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow playing uploaded sounds through the music player w/ Webroot #4934

Merged
merged 11 commits into from
Nov 22, 2023

Conversation

fira
Copy link
Member

@fira fira commented Nov 14, 2023

About the pull request

Too long have we suffered at the hands of admin auditive abuse.

The prophet, spookydonut, once said, "You shouldn't be using this lol". And he was right. Using "Play MIDI sound" both reduces usability for our users, and can cause performance issues by freezing up the game for a while as the data is transfered to these 200 poor CM addicts.

So we sought to alienate it with "Play Internet Sound" backed by youtube-dl. Unfortunately, some things are subject to geo blocking or simply not available on Youtube. Thus the regime of terror of Admins continues.

This PR brings us one step closer to our goal: it allows to use the now renamed "Play Admin Sound" to (also) upload a sound file to Webroot and have it played through CDN. It also works with simple transport but that mostly defeats the point.

Also reduced default volume for new players from 50% to 20%... Don't worry, It's still way more than enough to get them to quit the server, i have mine at 2-10% max

Explain why it's good for the game

  • Less new player abuse by reducing default volume
  • More performance by allowing big or custom songs to be backed by CDN
  • Better UX: People can easily see the song name and more easily stop it
  • Admins can now hide the name of played songs if they want to. Don't ask me why.

Testing Photographs and Procedure

image
You'll have to believe me on the sound working

Changelog

🆑
balance: Default Web Music Player volume is now 20% down from 50%. It was found too effective against new players.
admin: "Play Internet Sound" is now "Play Admin Sound" and optionally allow to hide the track name.
admin: "Play Admin Sound" can now be used with uploaded tracks, which use CDN delivery and the in-chat music player, granting players more control over them.
admin: Removed "Play Midi Sound".
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Admin Make things harder for admins labels Nov 14, 2023
@fira fira added the Do Not Merge If you merge this PR, I will annihilate you label Nov 14, 2023
@fira fira changed the title You can now play uploaded sounds through the music player w/ Webroot Allow playing uploaded sounds through the music player w/ Webroot Nov 15, 2023
@fira fira removed the Do Not Merge If you merge this PR, I will annihilate you label Nov 15, 2023
@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Nov 15, 2023
@Zonespace27
Copy link
Contributor

After many hours of careful consideration, I have determined the balance is acceptable.

Copy link
Contributor

@spookydonut spookydonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fira
Copy link
Member Author

fira commented Nov 15, 2023

https://github.com/cmss13-devs/cmss13/pull/4934/files#diff-e4659e01d523f65c28d6386ea09f2556f7ef6989a8b18e654824c7cd99fcafe1L108

delete this

done, removed it, play admin sound now works off simple transport too as a fallback
on the plus side that means people can't misuse the old one

@fira fira added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Nov 16, 2023
@harryob harryob added this pull request to the merge queue Nov 22, 2023
Merged via the queue into cmss13-devs:master with commit 15086ae Nov 22, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Make things harder for admins Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Testmerge Candidate we'll test this while you're asleep and the server has 10 players UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants