-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow playing uploaded sounds through the music player w/ Webroot #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
deletes nanoui/html
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Admin
Make things harder for admins
labels
Nov 14, 2023
fira
changed the title
You can now play uploaded sounds through the music player w/ Webroot
Allow playing uploaded sounds through the music player w/ Webroot
Nov 15, 2023
Zonespace27
added
the
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
label
Nov 15, 2023
After many hours of careful consideration, I have determined the balance is acceptable. |
spookydonut
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, removed it, play admin sound now works off simple transport too as a fallback |
fira
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Nov 16, 2023
3 tasks
3 tasks
3 tasks
harryob
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Admin
Make things harder for admins
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
UI
deletes nanoui/html
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Too long have we suffered at the hands of admin auditive abuse.
The prophet, spookydonut, once said, "You shouldn't be using this lol". And he was right. Using "Play MIDI sound" both reduces usability for our users, and can cause performance issues by freezing up the game for a while as the data is transfered to these 200 poor CM addicts.
So we sought to alienate it with "Play Internet Sound" backed by youtube-dl. Unfortunately, some things are subject to geo blocking or simply not available on Youtube. Thus the regime of terror of Admins continues.
This PR brings us one step closer to our goal: it allows to use the now renamed "Play Admin Sound" to (also) upload a sound file to Webroot and have it played through CDN. It also works with simple transport but that mostly defeats the point.
Also reduced default volume for new players from 50% to 20%... Don't worry, It's still way more than enough to get them to quit the server, i have mine at 2-10% max
Explain why it's good for the game
Testing Photographs and Procedure
You'll have to believe me on the sound working
Changelog
🆑
balance: Default Web Music Player volume is now 20% down from 50%. It was found too effective against new players.
admin: "Play Internet Sound" is now "Play Admin Sound" and optionally allow to hide the track name.
admin: "Play Admin Sound" can now be used with uploaded tracks, which use CDN delivery and the in-chat music player, granting players more control over them.
admin: Removed "Play Midi Sound".
/:cl: