-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape-pod stasis fixes & ID checking proc #4960
Escape-pod stasis fixes & ID checking proc #4960
Conversation
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
PR converts most places that are comparing registered_name on an ID, to a mob. I have left places that are explicitly checking for things without use of a direct user, as there are instances where this is necessary.
I have also fixed a missing check on escape pod stasis bays allowing xenos to put people into them.
In addition to the above change, I have set it so that people who were forced into stasis can eject themselves as there have been cases where people were removed from the round by this against their wishes.
Explain why it's good for the game
Makes little sense for xenos to be strapping marines into stasis bays. Nor for corpses to be accepted either, as they're not from the base version.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Added a proc for comparing the registered name of an ID, to the real name of a mob. Also checks registered_ref if one exists.
add: Evacuation can no longer be cancelled without passing above check.
add: People forced into escape-pod stasis bays against their wishes can now eject themselves.
fix: Xenos can no longer force humans into escape-pod stasis bays.
fix: Escape-pod stasis bays no longer accept corpses.
/:cl: