Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes screen alert tooltips getting stuck open #5349

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

SabreML
Copy link
Member

@SabreML SabreML commented Dec 31, 2023

About the pull request

Fixes #5344 by making alert tooltips close when the user's mouse exits the alert.
(This is how it work on other codebases that I've checked, so I guess it was just accidentally left out when alerts were ported here?)

Explain why it's good for the game

Tooltips should be able to open and close.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Fixed screen alert tooltips ('Buckled' indicator and stuff) getting stuck open.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Dec 31, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine and I can confirm this works.

@Drulikar Drulikar added this pull request to the merge queue Jan 1, 2024
Merged via the queue into cmss13-devs:master with commit ba63137 Jan 1, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Buckled Info Tip Buckling A Little Too Much!
2 participants