-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Databasing whitelists #5402
Merged
harryob
merged 30 commits into
cmss13-devs:master
from
realforest2001:databasing/whitelists
Jan 22, 2024
Merged
Databasing whitelists #5402
harryob
merged 30 commits into
cmss13-devs:master
from
realforest2001:databasing/whitelists
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Mapping
did you remember to save in tgm format?
UI
deletes nanoui/html
Feature
Feature coder badge
Refactor
Make the code harder to read
labels
Jan 8, 2024
ghost
reviewed
Jan 8, 2024
harryob
requested changes
Jan 8, 2024
harryob
requested changes
Jan 8, 2024
fira
added
the
Do Not Тestmerge
I will find you and I will testmerge you into the ground if you even think about testmerging this.
label
Jan 8, 2024
Testing with @harryob led to the discovery that SOMETHING in here is causing admin holders to not associate properly. We have no idea why at this time though. |
USS Runtime is changed, seems to have added another Z level? @realforest2001 |
3 tasks
3 tasks
harryob
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
In theory, this should now make whitelists entirely controllable by their senators/the overseer(s) without direct management input.
Major thanks to HarryOB for the major base of this code, all I did is make the UI and some code.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Added Whitelist Panel for whitelist senators to manage their own whitelists.
refactor: Whitelist.txt is no longer functional, owing to the new system.
del: Removed "Alien Whitelist" checks regarding base SS13 races.
/:cl: