Fix Weird Inventories #5525
Merged
Fix Weird Inventories #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for nomoveupdate - nor does replicating what TG does with it seem to work for us w/o other changes)
3 tasks
harryob
approved these changes
Jan 24, 2024
cm13-github
added a commit
that referenced
this pull request
Jan 24, 2024
3 tasks
This was referenced Jan 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR resolves the unresolved issues in #5337 and should fix #4604 See testing for more details.
One note is that we aren't actually doing anything different for mob/proc/u_equip for nomoveupdate. I attempted a few things including a snippet from tg's code (https://github.com/tgstation/tgstation/blob/master/code/modules/mob/inventory.dm#L377-L381) but at least for thrown items it would just make them poof; so for now I just corrected a misused call of it.
Explain why it's good for the game
No more funny business nor weird inventory overlays (atleast for cards and stacks - let me know if there is anything else that has this behavior)
Testing Photographs and Procedure
Screenshots & Videos
Busted:
Busted.mp4
Fixed:
Fixed.mp4
Changelog
🆑 Drathek
fix: Fixed more item exploits
fix: Fixed lingering overlays in inventories for metal stacks and cards
/:cl: