-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes queen not being able to spawn #6077
Conversation
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this code is functional, even in the situation where someone evolves before the queen picks a location. But you ought to also adjust QUEEN_SPAWN_TIMEOUT to be ~1 minute or so. It took approximately 1 minute and 20s for me as a larva spawn to evolve to queen.
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Surprised? |
Not what I'm conveying. What I was conveying is this probably wouldn't even be necessary if the timer didn't allow people to evolve before queen is forced to pick a location. But I don't know how client disconnects might get handled so the code is fine to have that logic since it should kick them back to lobby even if disconnected - or at least tries to. |
About the pull request
Fixes #5999
Explain why it's good for the game
bug fix
Changelog
🆑
fix: fixes queen getting stuck in the lobby if they take too long
/:cl: