Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise Corpsespawner Limit #7389

Merged
merged 9 commits into from
Nov 7, 2024
Merged

Raise Corpsespawner Limit #7389

merged 9 commits into from
Nov 7, 2024

Conversation

BOBAMAx
Copy link
Contributor

@BOBAMAx BOBAMAx commented Oct 26, 2024

About the pull request

Raises corpsespawner quota from 25 to 100. Limits intel points from human corpses to 5 (50 bodies).
Adds a bunch of corpsespawners to Trijent. Adds a couple to shivas and fiorina. Removes a bunch from solaris.

This would likely need a TM to see if the increased amount of bodies impacts server performance.

Explain why it's good for the game

As it stands right now, there is a hard limit on 25 corpses per map. On a map like LV-624 this is mostly OK as it's fairly small and the corpsespawners are fairly spread out. On a map like Trijent and potentially Hybrisa, this severely limits the amount of bodies the average player will see in a given round. You would expect bigger maps to have more bodies but this is not the case. This has negatively affected Solaris specifically because the map has almost 100 corpsespawners, many of which are in caves or research labs, making the colony proper nearly devoid of life. Mappers are also in an arms race, competing for the 25 corpse spots in their map additions.

Big Red needs to have some of it's corpse spawners removed if the limit is raised as many of these were placed down with the assumption that not all of them were going to spawn at once.

Trijent now looks more like a xenomorph outbreak has swept through the colony and less like the rapture occured and everyone vanished without a trace.

Shivas has a few extra bodies now.

Fiorina had almost no prisoner and scientist bodies and almost exclusively guard bodies. Isn't much of a prison science annex with no prisoners or scientists.

non-comprehensive before and after:

before

bigred1

after

bigred4

some trijent stuff

trijent1
trijent2

There doesn't need to ever be 10 bodies stuffed in the Eta locks but because the mapper wanted there to always be a couple, he put down ten to make it likely that a few would actually spawn. This is roundabout and stupid and causes "individual" corpsespawners to very rarely actually spawn a corpse, which is unintuitive from the mapper's perspective.

Also limits intel points from human bodies to prevent IOs from printing intel points from maps/inserts with a bunch of bodies.

Testing Photographs and Procedure

Tested by starting big red on local and using my eyes. Also killed a bunch of dudes in research and human bodies stopped giving points after 5.

Changelog

🆑 BOBAMA
maptweak: quadrupled the limit for roundstart corpses on maps.
maptweak: Removed Corpses from Solaris. Added corpses to Shivas, Fiorina, and Trijent
maptweak: added some "last stand" holds to Trijent and Shivas to put bodies in. Trijent research lab had most CMB weapons replaced with corporate/goon stuff.
balance: Intel points from human bodies are now capped at 5 (50 bodies)
/:cl:

@cmss13-ci cmss13-ci bot added the Code Improvement Make the code longer label Oct 26, 2024
@RainbowStalin
Copy link

As this affects intel points as well, shouldn’t the balance tag be added as well?

@Zenith00000
Copy link
Contributor

Good idea, Hybrisa technically has 75 bodies including those on the roller beds, not including burst bodies at all. Which considering the size you rarely see, this would help gathering intel on Hybrisa a lot. The bodies also add to the soul/atmosphere, it's kinda sad when you just see pools of blood with no body spawning ect.

@cmss13-ci cmss13-ci bot added the Mapping did you remember to save in tgm format? label Oct 29, 2024
@BOBAMAx BOBAMAx marked this pull request as ready for review October 29, 2024 07:26
@BOBAMAx BOBAMAx requested a review from Nanu308 as a code owner October 29, 2024 07:26
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 29, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Oct 29, 2024
@Nanu308 Nanu308 added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Oct 31, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing, tldr. Human tick and dead body impact on performance used to be the reason we had a set limit. On a side note, 100 is probably way too much.

@Drulikar Drulikar added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. labels Oct 31, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Oct 31, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 1, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github added a commit that referenced this pull request Nov 1, 2024
cm13-github added a commit that referenced this pull request Nov 1, 2024
@cm13-issue-bot cm13-issue-bot mentioned this pull request Nov 1, 2024
@thevandie thevandie mentioned this pull request Nov 1, 2024
3 tasks
@Drulikar Drulikar removed the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Nov 1, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Nov 5, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Nov 6, 2024
@Drulikar Drulikar removed the Needs Testing Need to test it on the guinea pigs (production server) label Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
cm13-github added a commit that referenced this pull request Nov 6, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm now

@Nanu308 Nanu308 added Mapping Approved adds 500 new dict keys Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. labels Nov 7, 2024
@Nanu308
Copy link
Member

Nanu308 commented Nov 7, 2024

Might need to move corpses/look at corpse loot in future but this is fine

cm13-github added a commit that referenced this pull request Nov 7, 2024
@Drulikar Drulikar added this pull request to the merge queue Nov 7, 2024
Merged via the queue into cmss13-devs:master with commit 63214cd Nov 7, 2024
27 checks passed
cmss13-ci bot added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants