Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Shrapnell Buff + Shrapnel rocket now shoots directional shrapnell #7581

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Nov 13, 2024

About the pull request

Increases shrapnell damage accuracy and damage .
Rockets will now shoot their shrapnell (if they have any) in a 90 angle facing the objective.

Explain why it's good for the game

Currently Shrapnell is near useless in combat against both xenos and humans . this PR aims to make shrapnell more usefull by having greater accuracy.

The objective of this is having shrapnel have a somewhat consistent output on dmg . instead of being fully RNG . specially on xenomorph . currently ingame an entire 200 shrap mortar can land next to you and you only get about 100 dmg as most of them will miss.

rocket now shoots its shrapnell directionally so the operator doesnt kill itself and others with it .

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Shrapnell accuracy and damage increased
balance: Shrapnell now does 60% bonus damage to xenomorphs
balance: Shrapnell slows xenomorphs on hit
balance: Custom rockets will now shoot their shrapnell on a 90 degree angle
/:cl:

@cmss13-ci cmss13-ci bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Nov 13, 2024
@GoldenDarkness55
Copy link
Contributor

Can you make something like the blast dampener except with the effect of angling shrapnel instead? Would be better to keep it optional (wculd it also work on grenades then?)

As for shrap you'l shouldnt be removing embed chance and lowering pen. Accurate_range_min has to be kept at 1 to prevent single mobs eating insane shrap amounts.
Likely better to make a custom shrap type for OT with higher accuracy and damage but capped to 6 range with heavy falloff around 4 so you take 0-10 DMG on max tile to prevent ff, since as long as the range ff potential remains they won't work for HvX. Would have to make a mortar subtype with proper range though - frag shells already need buffs anyway

@Diegoflores31
Copy link
Contributor Author

Diegoflores31 commented Nov 13, 2024

Can you make something like the blast dampener except with the effect of angling shrapnel instead? Would be better to keep it optional (wculd it also work on grenades then?)

on grenades it kinda makes no sense unless we make a new AGM for OT or smth.

the values you see i "deleted" are still there its just that they come from inheritance

min_accurate_range = 0 is necesary . its normal to eat big amounts of dmg if you are point blank of an hefa . remember the shrapnel amount is divided by 4 per tile traveled . on xenos is really hard to die from even with new values .

i want it on main shrap because ngl all shrap is weak as hell currently . (hail hefa)

@Diegoflores31
Copy link
Contributor Author

Diegoflores31 commented Nov 14, 2024

UPDATE :
Shrapnell damage now slows(normal slow) xenos on hit for 4 seconds ( it doesnt stack ) ((AGM superslow will be removed))
Shrapnell does 1.6 of its normal dmg to xenomorphs ( about 45 on paper , tested ingame is about 39-40 with no armor )

This changes have been tested ingame . HEFA is now about the same as HE (for targets with no armor, HE does more dmg to armored targets ) but winout the stun which is compensated by the shrapnell slow

@hry-gh
Copy link
Member

hry-gh commented Dec 16, 2024

UPDATE : Shrapnell damage now slows(normal slow) xenos on hit for 4 seconds ( it doesnt stack ) ((AGM superslow will be removed)) Shrapnell does 1.6 of its normal dmg to xenomorphs ( about 45 on paper , tested ingame is about 39-40 with no armor )

This changes have been tested ingame . HEFA is now about the same as HE (for targets with no armor, HE does more dmg to armored targets ) but winout the stun which is compensated by the shrapnell slow

changelog?

@hry-gh hry-gh marked this pull request as draft December 16, 2024 10:04
@Diegoflores31 Diegoflores31 marked this pull request as ready for review January 4, 2025 20:27
@Diegoflores31 Diegoflores31 changed the title Buffs Shrapnel Custom rockets will now shoot shrapnell in a 90 degree angle Standard Shrapnell Buff , Shrapnel rocket now shoots directional shrapnell Jan 4, 2025
@Diegoflores31 Diegoflores31 changed the title Standard Shrapnell Buff , Shrapnel rocket now shoots directional shrapnell Standard Shrapnell Buff + Shrapnel rocket now shoots directional shrapnell Jan 4, 2025
cm13-github added a commit that referenced this pull request Jan 6, 2025
@kiVts
Copy link
Contributor

kiVts commented Jan 6, 2025

No idea how it will perform.

@kiVts kiVts added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jan 6, 2025
cm13-github added a commit that referenced this pull request Jan 7, 2025
cm13-github added a commit that referenced this pull request Jan 7, 2025
cm13-github added a commit that referenced this pull request Jan 7, 2025
@kiVts kiVts removed the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jan 7, 2025
@kiVts kiVts added this pull request to the merge queue Jan 7, 2025
Merged via the queue into cmss13-devs:master with commit 46f3bd9 Jan 7, 2025
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants