Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM ONLY] EVENT WL MERRY CHIRMSTIKMASM #7830

Closed
wants to merge 9 commits into from

Conversation

irakligabunia
Copy link
Contributor

@irakligabunia irakligabunia commented Dec 16, 2024

About the pull request

this lets a person play every WL if they have 1 WL

Explain why it's good for the game

GLOBALISM PLOT BY THE PREDS UNCOVERED
In all seriousness, I want people to try being in eachother's shoes. This is pending event approval, as I want to host it on christmas
(7th of January)

Testing Photographs and Procedure

god told me this would work

Changelog

🆑 stalkerino
add: lets people play all WLs if they have 1 WL
/:cl:

@irakligabunia
Copy link
Contributor Author

will test branch today

@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Dec 16, 2024
@irakligabunia irakligabunia marked this pull request as draft December 16, 2024 15:54
@irakligabunia irakligabunia marked this pull request as ready for review December 16, 2024 16:48
@irakligabunia

This comment was marked as off-topic.

@Strobia

This comment was marked as off-topic.

@Lukas-Seltz

This comment was marked as off-topic.

@Strobia

This comment was marked as off-topic.

@Lukas-Seltz

This comment was marked as off-topic.

@Drulikar Drulikar added Do Not Merge If you merge this PR, I will annihilate you Test Merge Only This PR's purpose is for testmerges only. labels Dec 17, 2024
@Lukas-Seltz

This comment was marked as off-topic.

@cmss13-devs cmss13-devs locked as off-topic and limited conversation to collaborators Dec 17, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you didn't test :P

With the suggested changes:
image
Though I'll note doing it how you're doing it will be a bit funky:

  • The whitelist panel will incorrectly toggle on these now grouped whitelists when reading their value
  • The whitelist panel will only write the value(s) you select but the player being modified will only have the whitelist you just wrote. When the game restarts or ultimately whitelists are re-read, then they will have the grouped whitelists again.

So that's to say:

  • If you're going to use the whitelist panel, but sure to only assign values you want to linger
  • When updating whitelists using the whitelist panel, they won't get access to the other whitelists until the next round.

Also worth noting in case you intended otherwise: The automatic staff whitelist for working joe does not grant them the other whitelists with this code. They would have to explicitly be whitelisted for working joe to get the other whitelists.

code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
irakligabunia and others added 5 commits December 17, 2024 13:45
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
@Drulikar
Copy link
Contributor

#7840 was required for the linters

@Drulikar
Copy link
Contributor

Event over.

@Drulikar Drulikar closed this Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge Test Merge Only This PR's purpose is for testmerges only.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants