-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TM ONLY] EVENT WL MERRY CHIRMSTIKMASM #7830
Conversation
will test branch today |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you didn't test :P
With the suggested changes:
Though I'll note doing it how you're doing it will be a bit funky:
- The whitelist panel will incorrectly toggle on these now grouped whitelists when reading their value
- The whitelist panel will only write the value(s) you select but the player being modified will only have the whitelist you just wrote. When the game restarts or ultimately whitelists are re-read, then they will have the grouped whitelists again.
So that's to say:
- If you're going to use the whitelist panel, but sure to only assign values you want to linger
- When updating whitelists using the whitelist panel, they won't get access to the other whitelists until the next round.
Also worth noting in case you intended otherwise: The automatic staff whitelist for working joe does not grant them the other whitelists with this code. They would have to explicitly be whitelisted for working joe to get the other whitelists.
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
Co-authored-by: Drathek <76988376+Drulikar@users.noreply.github.com>
#7840 was required for the linters |
Event over. |
About the pull request
this lets a person play every WL if they have 1 WL
Explain why it's good for the game
GLOBALISM PLOT BY THE PREDS UNCOVERED
In all seriousness, I want people to try being in eachother's shoes. This is pending event approval, as I want to host it on christmas
(7th of January)
Testing Photographs and Procedure
god told me this would work
Changelog
🆑 stalkerino
add: lets people play all WLs if they have 1 WL
/:cl: