-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes maintainer access to the profiler and clears profiler access whenever admins are loaded. #7909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why on event server this works (after a reconnect - not first connect); but not on live (even with reconnects). I can confirm for both servers the cfg/admin.txt is assigned to be some_ckey role=admin
for only those who have connected this round, and the perms for the file are the same for both servers.
But the aspect of requiring a reconnect is wonky as is. So try setting up the admin.txt during init (e.g. after load_admin_ranks) rather than on associate?
I was doing testing with harryob, and the admin.txt was getting populated with ckeys. The problem isn't related to code, it's related to the cm-live server and it's unclear what might be causing it. In any case, this PR is still useful to merge since it clears up a potential vulnerability where people stay in the admin.txt despite probably not being an admin anymore. |
About the pull request
As explained by the title.
Explain why it's good for the game
Prevents a vulnerability where someone who previously had access to the profiler retains access despite no longer requiring it.
No player facing change so changelog not needed