Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mortar Changes #8015

Merged
merged 18 commits into from
Feb 8, 2025
Merged

Mortar Changes #8015

merged 18 commits into from
Feb 8, 2025

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Jan 5, 2025

About the pull request

Exact numbers are absent on purpose as everything is subject to change

  1. Removed free mortar shells from ASRS
  2. Lowered the initial cost for all mortar shells
  3. Mortar range is now limited
  4. Incendiary mortar shell is now purely incendiary
  5. Fragmentation mortar shell shrapnel now deals bonus damage against structures, similar to masterkey shotgun

Explain why it's good for the game

1. Removed free mortar shells from ASRS

This should have never been given out for free, besides the fact it removes the logistical chain (Free from asrs -> FOB is not a logistical chain) in your average round by the time xenos push out of caves mortar has enough shells to continuously fire for the next hour.

2. Lowered the initial cost for all mortar shells

With the above change, to encourage req to actually buy mortar shells.

3. Mortar range is now limited

Nobody enjoys fire support without counterplay, to move away from that kind of artillery the range of the mortar is now limited, forcing it to move along with the front and giving an opportunity for xenomorphs to disable it if it not properly defended. This also requires the moving of shells from FOB to other areas around the map, which is an actual logistical effort.

4. Incendiary mortar shell is now purely incendiary

I don't know why, however for the longest time incendiary mortar shells had nearly the exact same explosive power as HE shells, rendering them as 'bait' to buy, combining this with the long duration of the green fire - all other mortar shells were rendered obsolete.

5. Fragmentation shells

A buff for the least used kind of shell, hoping to see it more in action, might need to be adjusted.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Mortar range is now limited.
balance: Removed free mortar shells from ASRS.
balance: Lowered the initial costs of mortar shells for requisitions.
balance: Incendiary mortar shells are now purely incendiary.
balance: Fragmentation shell shrapnel now deals bonus damage to structures.
/:cl:

@cmss13-ci cmss13-ci bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jan 5, 2025
@Red-byte3D
Copy link
Member

Red-byte3D commented Jan 5, 2025

if the mortar is going to be moving around or to the front, you should increase the backpack / belt storage options to counteract for the fact

Copy link
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

@kiVts kiVts added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jan 7, 2025
cm13-github added a commit that referenced this pull request Jan 7, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 7, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 7, 2025
cm13-github added a commit that referenced this pull request Jan 7, 2025
cm13-github added a commit that referenced this pull request Jan 7, 2025
@dunsel-hordon
Copy link

honestly not a great change as most of the maps already are half covered areas anyways. The shell changes however would be a better place to implement these range changes for various benefits / detriments. Could have longer range shells that do less damage or are more inaccurate or shorter range more precise shells with higher damage. Just my 2 cents on it.

@sippykot
Copy link

sippykot commented Jan 7, 2025

yeah, no, this is a bad change
nerfing the mortar this much makes it just... bad?

Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

maps/map_files/USS_Almayer/USS_Almayer.dmm Show resolved Hide resolved
@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jan 18, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 31, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Feb 1, 2025
Git-Nivrak and others added 2 commits February 1, 2025 14:16
e150f01: maps/map_files/USS_Almayer/USS_Almayer.dmm

Automatically commited by: tools\mapmerge2\fixup.py
@Blundir Blundir added the Sprites Approved confirmed no stray pixels label Feb 5, 2025
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Feb 7, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@hry-gh hry-gh enabled auto-merge February 8, 2025 09:55
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Feb 8, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

2494276: maps/map_files/USS_Almayer/USS_Almayer.dmm

Automatically commited by: tools\mapmerge2\fixup.py
@hry-gh hry-gh added this pull request to the merge queue Feb 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 8, 2025
@hry-gh hry-gh added this pull request to the merge queue Feb 8, 2025
Merged via the queue into cmss13-devs:master with commit 3a94024 Feb 8, 2025
24 checks passed
cmss13-ci bot added a commit that referenced this pull request Feb 8, 2025
@Dicerson
Copy link

Dicerson commented Feb 8, 2025

Nobody enjoys fire support with counterplay

ohkay cool, so when are the dropships having all of their guns removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.