fix: unable to change rank in security records console, feat: add security record delete button, secure deleting all records #8016
Conversation
feat: add record delete button, secure deleting all records Fixes CIC/MPs don't have access to change records cmss13-devs#7986
|
Aside from CO having the change rank button this is fine. |
Is there then any reason to even have rank field editable then? It'll probably confuse every player that it's clickable and will arise more bug reports like this one #7986. |
| temp = "" | ||
| temp += "Personal record deleted." |
There was a problem hiding this comment.
| temp = "" | |
| temp += "Personal record deleted." | |
| temp = "Personal record deleted." |
| temp = "" | ||
| temp += "Are you sure you wish to delete [active1.fields["name"]] record?<br>This action may result in irreversible data loss.<br>" |
There was a problem hiding this comment.
| temp = "" | |
| temp += "Are you sure you wish to delete [active1.fields["name"]] record?<br>This action may result in irreversible data loss.<br>" | |
| temp = "Are you sure you wish to delete [active1.fields["name"]] record?<br>This action may result in irreversible data loss.<br>" |
| temp += "<a href='byond://?src=\ref[src];choice=Purge All Records'>Yes</a>" | ||
| temp += "<a href='byond://?src=\ref[src];choice=Clear Screen'>No</a>" | ||
| else | ||
| alert(usr, "You do not have the required rank to do this!") |
| temp = "" | ||
| temp += "Are you sure you wish to delete all Security records?<br>This action may result in irreversible data loss.<br>" |
There was a problem hiding this comment.
| temp = "" | |
| temp += "Are you sure you wish to delete all Security records?<br>This action may result in irreversible data loss.<br>" | |
| temp = "Are you sure you wish to delete all Security records?<br>This action may result in irreversible data loss.<br>" |
| if (id_card) | ||
| if ( (id_card.paygrade in GLOB.co_paygrades) || (id_card.paygrade in GLOB.uscm_highcom_paygrades)) | ||
| return TRUE |
There was a problem hiding this comment.
| if (id_card) | |
| if ( (id_card.paygrade in GLOB.co_paygrades) || (id_card.paygrade in GLOB.uscm_highcom_paygrades)) | |
| return TRUE | |
| if(id_card && (id_card.paygrade in GLOB.co_paygrades) || (id_card.paygrade in GLOB.uscm_highcom_paygrades)) | |
| return TRUE |
| @@ -564,3 +587,14 @@ What a mess.*/ | |||
| /obj/structure/machinery/computer/secure_data/detective_computer | |||
| icon = 'icons/obj/structures/machinery/computer.dmi' | |||
| icon_state = "messyfiles" | |||
|
|
|||
| /obj/structure/machinery/computer/secure_data/proc/can_perform_restricted_actions(mob/user) | |||
| if (ishuman(user)) | |||
|
Currently this whole merge request is going through rework, due to rewriting whole security records console to TGUI. |
Said changes are included in this PR:https://github.com/cmss13-devs/cmss13/actions/runs/12876851743/job/35900464089?pr=8191I'm closing this as scope of changes dramatically changed and they deserve another PR. |
About the pull request
This pull request improves slightly security records console.
I've fixed changing rank, so players on CO or Highcom paygrade are now actually able to change it in records.
This pull request also add option for authorized personel (CO/Highcom) to delete single record from console.
There've been some problems regarding records before, when MPs added them, but were unable to delete them. Now they at least can ask CO or contact highcom to delete those.
I've also secured removing all security records function, cause it doesn't seem for me like everybody with access to console, should be able to access that.
Fixes CIC/MPs don't have access to change records #7986
I've tested this change with Command, Highcomm and MPs players, didn't see any issues.
Explain why it's good for the game
CO/Highcom should be able to change person's rank in security records.
CO/Highcom should be able to delete personal records.
Only CO/Highcom should be able to bulk delete all security records.
I did that change cause I've been affected by this many times, made some records and were not able to delete them or modify in reasonable way.
I'm aware that whole console needs major rework, but those changes should be present to at least make security records somewhat maintainable.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: unable to change rank in security records console
add: add security record delete button
add: secure deleting all records
/:cl: