-
Notifications
You must be signed in to change notification settings - Fork 201
Introduce templated benchmarks. #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 62 commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
5e9b202
Draft for templated benchmarks.
anjagruenheid 59bf5d9
Update src/main/java/com/oltpbenchmark/benchmarks/templated/Templated…
anjagruenheid b6cebe2
Update src/main/java/com/oltpbenchmark/benchmarks/templated/util/Gene…
anjagruenheid 7041b47
Address initial comments.
anjagruenheid 385cb5f
Merge branch 'templated_benchmarks' of https://github.com/anjagruenhe…
anjagruenheid 7b24a23
Add plugin definition.
anjagruenheid 4dbb248
Add missing changes.
anjagruenheid 9115389
Set parameter type as string
anjagruenheid a3ea10a
bugfix
anjagruenheid e49749f
Debugging parameter types/values.
anjagruenheid c8e1bc1
bugfix
anjagruenheid 398cea2
more fixes
anjagruenheid 6fc00dd
Change param value propagation.
anjagruenheid 4ae2f05
Remove debugging messages.
anjagruenheid 62fd06a
Update src/main/java/com/oltpbenchmark/benchmarks/templated/util/Trac…
anjagruenheid 08d5dda
Merge branch 'main' into templated_benchmarks
bpkroth 277d3ac
Update src/main/java/com/oltpbenchmark/benchmarks/templated/README.md
anjagruenheid 7f12c52
Attempt to indrocue XML validation for templates.
anjagruenheid 481b060
Merge branch 'templated_benchmarks' of https://github.com/anjagruenhe…
anjagruenheid 7990a31
Fix template file and some minor comments.
anjagruenheid fc8845b
Simplifying names.
anjagruenheid 5753221
bugfix
anjagruenheid 26f94ff
Debugging reading the xml.
anjagruenheid e52bd6c
remove superfluous file.
anjagruenheid 207c890
debugging
anjagruenheid f59cf4e
more debugging.
anjagruenheid ee7a334
trying to solve the problem
anjagruenheid 017f109
Remove debugging information.
anjagruenheid d80910d
Adjust README to new names.
anjagruenheid 4b57597
Merge branch 'main' into templated_benchmarks
bpkroth d618799
Merge branch 'main' into templated_benchmarks
anjagruenheid c49255e
Merge branch 'main' into templated_benchmarks
bpkroth c1b8ef0
Merge branch 'main' into templated_benchmarks
anjagruenheid db230bb
Merge branch 'main' into templated_benchmarks
anjagruenheid 003e4bb
Merge branch 'main' into templated_benchmarks
anjagruenheid bf32eaf
Add templated benchmark to pipeline
anjagruenheid 66e703e
Merge branch 'main' into templated_benchmarks
anjagruenheid f3cce57
Update .github/workflows/maven.yml
anjagruenheid bb26b11
Update data/templated/example.xml
anjagruenheid 04fbb4b
Update config/sqlserver/sample_templated_config.xml
anjagruenheid 43796ae
Minor rephrases.
anjagruenheid 71ea51d
Fix execution error due to '--' in comment.
anjagruenheid 0b8e205
Comment adjustment.
anjagruenheid 643f2f0
Merge branch 'main' into templated_benchmarks
bpkroth dfb7d0e
markdown rendering cleanup, spelling, etc.
bpkroth 4faaa0e
add templated benchmark support checks for postgres as well
bpkroth dc0a7d5
enable templated benchmark
bpkroth d3e26b3
Merge pull request #1 from bpkroth/templated_benchmarks
anjagruenheid 2f24fbd
Update user name and password.
anjagruenheid 80a19a4
Remove superfluous imports.
anjagruenheid 683793d
Add a templated test for mysql.
anjagruenheid 3211f75
Add MariaDB test to pipeline.
anjagruenheid 4bee191
Add stripping to prevent integer errors.
anjagruenheid f7d5849
Debugging MariaDB issue.
anjagruenheid 37c4e6d
Fix debugging example
anjagruenheid c933663
Merge branch 'main' into templated_benchmarks
anjagruenheid 454d59b
More debugging.
anjagruenheid 4afc764
Confirm that the query is the issue.
anjagruenheid 22d5863
Reset and add explanation.
anjagruenheid b96bc10
Double checking hypothesis.
anjagruenheid 1b89af9
add support for running templated benchmarks in the docker script loc…
bpkroth be1e02e
add support for testing on sqlite as well, and locally via docker
bpkroth 8614a31
comments
bpkroth 24cf859
add a test for floating point queries
bpkroth fa355d5
add a log
bpkroth a04ee5d
adding unit tests for templated benchmarks
bpkroth fe58cad
remove the extra space for csv parsing issues
bpkroth 15de916
use the xml conf random seed
bpkroth 5e4167d
wip: fixups
bpkroth 5382b4f
remove the mariadb special case
bpkroth 6977cca
reduce the scale factor on sqlite
bpkroth cc0019b
work to make the unit tests work
bpkroth cd3e27e
tweaks
bpkroth fc5d734
fixup
bpkroth c7cc7a2
Add warning for procedure class type.
anjagruenheid 041ef09
Error instead of warning.
anjagruenheid 4a59b04
cleanup comment
bpkroth d838a27
add another NULL test
bpkroth ba099e6
TODO/FIXME comments for supporting nullable params
bpkroth 6631055
remove the strip
bpkroth 79db3d3
comments, unused import
bpkroth 3786be8
revert
bpkroth fabd76d
tweak
bpkroth 7f6c7aa
Merge remote-tracking branch 'anja/templated_benchmarks' into templat…
bpkroth e8b77fd
Merge branch 'main' into templated_benchmarks
anjagruenheid f396bdc
Merge pull request #2 from bpkroth/templated_benchmarks
anjagruenheid 058c515
Merge branch 'main' into templated_benchmarks
bpkroth 80c6e6b
Merge remote-tracking branch 'anja/templated_benchmarks' into templat…
bpkroth 681c0aa
enable templated benchmark for sqlite
bpkroth 4ef15ad
disable synchronous loading for tpcc for sqlite for tempalted benchmark
bpkroth 88f858f
fixups - can't override variables in java
bpkroth 3e5a803
fixup
bpkroth dc0329d
path fixup
bpkroth bc96fca
path fixups
bpkroth fc7fbe0
fixes for sqlserver syntax - wants TOP instead of LIMIT
bpkroth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
<?xml version="1.0"?> | ||
<parameters> | ||
|
||
<!-- Connection details --> | ||
<type>MARIADB</type> | ||
<driver>org.mariadb.jdbc.Driver</driver> | ||
<url>jdbc:mariadb://localhost:3306/benchbase?useServerPrepStmts</url> | ||
<username>admin</username> | ||
<password>password</password> | ||
<isolation>TRANSACTION_SERIALIZABLE</isolation> | ||
<batchsize>128</batchsize> | ||
|
||
<!-- Note: these example template reuses TPC-C queries and data as a demonstration, but others are possible. | ||
To test this sample as is, you must first run benchbase with parameters `load=true` and | ||
`config=sample_tpcc_config.xml` to load the TPC-C data to the target database. | ||
Other templated benchmarks need to ensure that the data is loaded manually prior to running the benchmark. | ||
|
||
For MariaDB specifically, templates cannot contain more than one wildcard ('?') parameter, otherwise the | ||
query will fail. | ||
--> | ||
|
||
<query_templates_file>data/templated/example_mariadb.xml</query_templates_file> | ||
|
||
<!-- The workload --> | ||
<terminals>1</terminals> | ||
<works> | ||
<work> | ||
<time>10</time> | ||
<rate>100</rate> | ||
<weights>30,30,40</weights> | ||
</work> | ||
</works> | ||
|
||
<!-- Select all templates that are executed. --> | ||
<transactiontypes> | ||
<transactiontype> | ||
<name>GetOrder</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetCust</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetWarehouse</name> | ||
</transactiontype> | ||
</transactiontypes> | ||
</parameters> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?xml version="1.0"?> | ||
<parameters> | ||
|
||
<!-- Connection details --> | ||
<type>MYSQL</type> | ||
<driver>com.mysql.cj.jdbc.Driver</driver> | ||
<url>jdbc:mysql://localhost:3306/benchbase?rewriteBatchedStatements=true&allowPublicKeyRetrieval=True&sslMode=DISABLED</url> | ||
<username>admin</username> | ||
<password>password</password> | ||
<isolation>TRANSACTION_SERIALIZABLE</isolation> | ||
<batchsize>128</batchsize> | ||
|
||
<!-- Note: these example template reuses TPC-C queries and data as a demonstration, but others are possible. | ||
To test this sample as is, you must first run benchbase with parameters `load=true` and | ||
`config=sample_tpcc_config.xml` to load the TPC-C data to the target database. | ||
Other templated benchmarks need to ensure that the data is loaded manually prior to running the benchmark. | ||
--> | ||
|
||
<query_templates_file>data/templated/example.xml</query_templates_file> | ||
|
||
<!-- The workload --> | ||
<terminals>1</terminals> | ||
<works> | ||
<work> | ||
<time>10</time> | ||
<rate>100</rate> | ||
<weights>30,30,40</weights> | ||
</work> | ||
</works> | ||
|
||
<!-- Select all templates that are executed. --> | ||
<transactiontypes> | ||
<transactiontype> | ||
<name>GetOrder</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetCust</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetWarehouse</name> | ||
</transactiontype> | ||
</transactiontypes> | ||
</parameters> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?xml version="1.0"?> | ||
<parameters> | ||
|
||
<!-- Connection details --> | ||
<type>POSTGRES</type> | ||
<driver>org.postgresql.Driver</driver> | ||
<url>jdbc:postgresql://localhost:5432/benchbase?sslmode=disable&ApplicationName=templated&reWriteBatchedInserts=true</url> | ||
<username>admin</username> | ||
<password>password</password> | ||
<isolation>TRANSACTION_SERIALIZABLE</isolation> | ||
<batchsize>128</batchsize> | ||
|
||
<!-- Note: these example template reuses TPC-C queries and data as a demonstration, but others are possible. | ||
To test this sample as is, you must first run benchbase with parameters `load=true` and | ||
`config=sample_tpcc_config.xml` to load the TPC-C data to the target database. | ||
Other templated benchmarks need to ensure that the data is loaded manually prior to running the benchmark. | ||
--> | ||
|
||
<query_templates_file>data/templated/example.xml</query_templates_file> | ||
|
||
<!-- The workload --> | ||
<terminals>1</terminals> | ||
<works> | ||
<work> | ||
<time>10</time> | ||
<rate>100</rate> | ||
<weights>30,30,40</weights> | ||
</work> | ||
</works> | ||
|
||
<!-- Select all templates that are executed. --> | ||
<transactiontypes> | ||
<transactiontype> | ||
<name>GetOrder</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetCust</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetWarehouse</name> | ||
</transactiontype> | ||
</transactiontypes> | ||
</parameters> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?xml version="1.0"?> | ||
<parameters> | ||
|
||
<!-- Connection details --> | ||
<type>sqlserver</type> | ||
<driver>com.microsoft.sqlserver.jdbc.SQLServerDriver</driver> | ||
<url>jdbc:sqlserver://localhost:1433;encrypt=false;database=benchbase;</url> | ||
<username>benchuser01</username> | ||
<password>P@ssw0rd</password> | ||
<isolation>TRANSACTION_SERIALIZABLE</isolation> | ||
<batchsize>128</batchsize> | ||
|
||
<!-- Note: these example template reuses TPC-C queries and data as a demonstration, but others are possible. | ||
To test this sample as is, you must first run benchbase with parameters `load=true` and | ||
`config=sample_tpcc_config.xml` to load the TPC-C data to the target database. | ||
Other templated benchmarks need to ensure that the data is loaded manually prior to running the benchmark. | ||
--> | ||
|
||
<query_templates_file>data/templated/example.xml</query_templates_file> | ||
anjagruenheid marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
<!-- The workload --> | ||
<terminals>1</terminals> | ||
<works> | ||
<work> | ||
<time>10</time> | ||
<rate>100</rate> | ||
<weights>30,30,40</weights> | ||
</work> | ||
</works> | ||
|
||
<!-- Select all templates that are executed. --> | ||
<transactiontypes> | ||
<transactiontype> | ||
<name>GetOrder</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetCust</name> | ||
</transactiontype> | ||
<transactiontype> | ||
<name>GetWarehouse</name> | ||
</transactiontype> | ||
</transactiontypes> | ||
</parameters> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
anjagruenheid marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<!-- Note: these example templates reuse TPC-C queries and data as a demonstration, but others are possible. --> | ||
<templates> | ||
<template name="GetOrder"> | ||
<query><![CDATA[SELECT NO_O_ID FROM new_order WHERE NO_D_ID = ? OR NO_D_ID = ? ORDER BY NO_O_ID ASC]]></query> | ||
<types> | ||
<type>INTEGER</type> | ||
<type>INTEGER</type> | ||
</types> | ||
<values> | ||
<value>3</value> | ||
<value>4</value> | ||
</values> | ||
<values> | ||
<value>5</value> | ||
<value>6</value> | ||
</values> | ||
</template> | ||
<template name="GetCust"> | ||
<query><![CDATA[SELECT C_DISCOUNT, C_LAST, C_CREDIT FROM customer WHERE C_W_ID = ?]]></query> | ||
<types> | ||
<type>INTEGER</type> | ||
</types> | ||
<values> | ||
<value>8</value> | ||
</values> | ||
</template> | ||
<template name="GetWarehouse"> | ||
<query><![CDATA[SELECT * FROM warehouse WHERE W_STREET_1 LIKE ?]]></query> | ||
<types> | ||
<type>VARCHAR</type> | ||
</types> | ||
<values> | ||
<value>Str</value> | ||
</values> | ||
</template> | ||
</templates> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- Note: these example templates reuse TPC-C queries and data as a demonstration, but others are possible. --> | ||
<templates> | ||
<template name="GetOrder"> | ||
<query><![CDATA[SELECT NO_O_ID FROM new_order WHERE NO_D_ID = ? OR NO_D_ID = ? ORDER BY NO_O_ID ASC]]></query> | ||
<types> | ||
<type>INTEGER</type> | ||
<type>INTEGER</type> | ||
</types> | ||
<values> | ||
<value>3</value> | ||
<value>4</value> | ||
</values> | ||
</template> | ||
<template name="GetCust"> | ||
<query><![CDATA[SELECT C_DISCOUNT, C_LAST, C_CREDIT FROM customer WHERE C_W_ID = ?]]></query> | ||
<types> | ||
<type>INTEGER</type> | ||
</types> | ||
<values> | ||
<value>8</value> | ||
</values> | ||
<values> | ||
<value>9</value> | ||
</values> | ||
</template> | ||
<template name="GetWarehouse"> | ||
<query><![CDATA[SELECT * FROM warehouse WHERE W_STREET_1 LIKE ?]]></query> | ||
<types> | ||
<type>VARCHAR</type> | ||
</types> | ||
<values> | ||
<value>Str</value> | ||
</values> | ||
</template> | ||
</templates> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.