fix(build): compile to wasm #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lmwnshn
approved these changes
Sep 21, 2022
Signed-off-by: Alex Chi <iskyzh@gmail.com>
skyzh
force-pushed
the
skyzh/rename-for-wasm
branch
from
bc9bff3 to
9316cc2
Compare
qiuyu21
pushed a commit
to qiuyu21/bustub
that referenced
this pull request
Oct 15, 2022
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi iskyzh@gmail.com
This PR includes changes on some headers.
PAGE_SIZEis defined in Emscripten, so we rename it toBUSTUB_PAGE_SIZE. Also clang-16 detects some issues with missingstd::before move.