Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall 2024 Project 3 #762

Merged
merged 26 commits into from
Oct 28, 2024
Merged

Fall 2024 Project 3 #762

merged 26 commits into from
Oct 28, 2024

Conversation

xx01cyx
Copy link
Member

@xx01cyx xx01cyx commented Oct 18, 2024

No description provided.

@xx01cyx xx01cyx marked this pull request as draft October 18, 2024 00:33
@xx01cyx xx01cyx marked this pull request as ready for review October 21, 2024 00:07
@connortsui20
Copy link
Member

Can we potentially separate the .slt files into a separate PR?

@xx01cyx
Copy link
Member Author

xx01cyx commented Oct 21, 2024

Can we potentially separate the .slt files into a separate PR?

Okay. Will update.

@xx01cyx
Copy link
Member Author

xx01cyx commented Oct 27, 2024

Can we potentially separate the .slt files into a separate PR?

See #767

prashanthduvvada
prashanthduvvada approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@prashanthduvvada prashanthduvvada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xx01cyx xx01cyx merged commit 2dd141e into master Oct 28, 2024
4 checks passed
@xx01cyx xx01cyx deleted the f24-p3 branch October 28, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanthduvvada prashanthduvvada prashanthduvvada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xx01cyx @connortsui20 @prashanthduvvada @yashkothari42