Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Pilot Preparation #1309

Merged
merged 129 commits into from
Dec 31, 2020
Merged

Pilot Preparation #1309

merged 129 commits into from
Dec 31, 2020

Conversation

rabbit721
Copy link
Contributor

@rabbit721 rabbit721 commented Nov 8, 2020 •
edited
Loading

Pilot Preparation Steps

Description

  • Created PilotThread that is spinning for pilot_planning flag to be enabled
  • Created Pilot that performs the initial planning steps when planning enabled:
    • Load predicted queries (current using queries pre-recorded using query trace recording as a work-around)
    • Execute the loaded queries while recording Operating Unit features using pipeline_metrics_enable and counters_enable

Remaining Tasks

  • Add code that communicates with Model Server Manager to do inference with the recorded pipeline features

Note

Resolving issue #1216

rabbit721 and others added 30 commits September 2, 2020 01:14
@rabbit721
initial commit for issue 1113
39eb9df
@rabbit721
Merge branch 'master' of https://github.com/cmu-db/terrier into master
9b5523f
@rabbit721
fix
598d86a
@rabbit721
fix problem in traffic_cop and in metrics_store.cpp
75335a7
@rabbit721
Merge branch 'master' of https://github.com/cmu-db/terrier into master
3123f2d
@rabbit721
fix style
4ed2f99
@rabbit721
fix style
2f4ba80
@rabbit721
Merge branch 'master' of https://github.com/cmu-db/terrier into master
ca38fb9
@rabbit721
added testing for query trace recording, removed resource metrics
49d6334
@rabbit721
fix style
373df3e
@rabbit721
Merge branch 'master' into master
70e0c62
@rabbit721
Merge branch 'master' of https://github.com/cmu-db/noisepage into master
c65ca66
@rabbit721
Merge branch 'master' of https://github.com/rabbit721/terrier into ma…
4e1f27e 
…ster
@rabbit721
fixed comments
50c9da2
@rabbit721
fix assertion
b104997
@rabbit721
added timestamp for query text
173e050
@rabbit721
fix merge in db_main
7a371da
@rabbit721
fix csv writing
d7678fb
@rabbit721
document timestamp param for RecordQueryText
3790ecb
@rabbit721
fix style
857205c
@linmagit
Merge branch 'master' into master
46253e6
@rabbit721
fix style
18ed3f8
@rabbit721
Merge branch 'master' of https://github.com/rabbit721/terrier into ma…
421fbfa 
…ster
@rabbit721
added include for string
1c51fa1
@rabbit721
fix style
458c2da
@rabbit721
fix style
e2cba7e
@rabbit721
Merge branch 'master' of https://github.com/cmu-db/noisepage into master
ce57450
@rabbit721
Merge branch 'master' of https://github.com/cmu-db/noisepage into master
b98b52b
@rabbit721
Merge branch 'master' of https://github.com/cmu-db/noisepage into master
b3cc020
@rabbit721
fixed bug in metrics_test.cpp
0ef4f04
linmagit
linmagit suggested changes Dec 24, 2020
View reviewed changes
Copy link
Member

@linmagit linmagit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work! A few small tweaks otherwise LGTM.

src/include/self_driving/forecast/workload_forecast.h Outdated Show resolved Hide resolved
src/include/self_driving/forecast/workload_forecast_segment.h Outdated Show resolved Hide resolved
src/include/self_driving/pilot/pilot.h Outdated Show resolved Hide resolved
src/include/self_driving/pilot/pilot.h Show resolved Hide resolved
src/include/self_driving/pilot/pilot.h Outdated Show resolved Hide resolved
src/self_driving/pilot/pilot.cpp Outdated Show resolved Hide resolved
src/include/self_driving/pilot/pilot.h Outdated Show resolved Hide resolved
src/self_driving/pilot_util.cpp Outdated Show resolved Hide resolved
src/self_driving/pilot_util.cpp Outdated Show resolved Hide resolved
src/self_driving/pilot_util.cpp Outdated Show resolved Hide resolved
@rabbit721 rabbit721 requested a review from linmagit December 27, 2020 16:09
@linmagit
Copy link
Member

@rabbit721 There were a few additional comments that I left last time if you click on the "Load more" button in between the review comments. GitHub will collapse some comments on the webpage if there're many comments.

linmagit
linmagit approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@linmagit linmagit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @rabbit721! Let's discuss the next steps on Thursday.

@linmagit linmagit added ready-to-merge This PR is ready to be merged. Mark PRs with this. and removed ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. labels Dec 29, 2020
@linmagit linmagit merged commit a84af21 into cmu-db:master Dec 31, 2020
jkosh44 pushed a commit to jkosh44/noisepage that referenced this pull request Feb 11, 2021
@rabbit721 @jkosh44
Pilot Preparation (cmu-db#1309)
a199c21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@linmagit linmagit linmagit approved these changes

Assignees

@rabbit721 rabbit721

Labels
feature Adds a requested feature ready-for-ci Indicate that this build should be run through CI. ready-to-merge This PR is ready to be merged. Mark PRs with this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rabbit721 @linmagit @lmwnshn @mbutrovich