This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Add the framework for the pg_statistic table. #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmwnshn
added
the
in-progress
lmwnshn
suggested changes
Jan 8, 2021
src/catalog/postgres/builder.cpp
Outdated
| parser::ConstantValueExpression(type::TypeId::INTEGER)); | ||
| columns.back().SetOid(PgStatistic::STAATTNUM_COL_OID); | ||
|
|
||
| // columns.emplace_back("stanullfrac", type::TypeId::DECIMAL, false, |
There was a problem hiding this comment.
@whoever-is-implementing the PR, Is this dead or not yet implemented? I think we'll need these columns as well as some binary array columns for topKs and histograms.
There was a problem hiding this comment.
@jkosh44 You'll probably be the one implementing it.
Add missing calls to Bootstrap and BootstrapPRIs. Rename the attributes to remove redundant _COL_OID suffix. Style nitpicks. noisepage is bootable again.
lmwnshn
added
ready-for-ci
|
Assuming this passes CI, @jkosh44 can you take a review pass since you'll be working with the PR and I've made some changes so I probably shouldn't be reviewing myself? Thanks! |
jkosh44
approved these changes
Jan 21, 2021
lmwnshn
added
in-progress
lmwnshn
added
ready-for-ci
Added missing RecoveryManager logic. Fixed the size of the PRI and PRM for statistic_oid_index in deletion. wow i was inattentive
Codecov Report
@@ Coverage Diff @@
## master #1416 +/- ##
==========================================
+ Coverage 82.39% 82.45% +0.06%
==========================================
Files 670 671 +1
Lines 46004 46107 +103
==========================================
+ Hits 37903 38016 +113
+ Misses 8101 8091 -10
Continue to review full report at Codecov.
|
lmwnshn
added
ready-to-merge
jkosh44
pushed a commit
to jkosh44/noisepage
that referenced
this pull request
Feb 11, 2021
Co-authored-by: Arvind Sai Krishnan <arvindsk@andrew.cmu.edu> Co-authored-by: Wan Shen Lim <wanshen.lim@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heading
Add the framework for the
pg_statistictable.Description
This PR adds the skeleton of
pg_statisticsupport.It does not currently track any statistics at all, apart from creating dummy column statistics in
pg_statisticand cleaning those entries up.