Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Assertion fail when insert and delete in the same transaction #1336

Closed
nwang57 opened this issue May 1, 2018 · 3 comments
Closed

Assertion fail when insert and delete in the same transaction #1336

nwang57 opened this issue May 1, 2018 · 3 comments
Labels

Comments

@nwang57
Copy link
Contributor

nwang57 commented May 1, 2018

create table foo(id integer);

begin;
insert into foo values(5);
delete from foo where id = 5;

The assertion failed at line 618 in src/concurrency/timestamp_ordering_transaction_manager.cpp. It seems that if the txn owns the tuple, it will not update the tuple's last reader id. So the commitId is 0 during the assertion.

@apavlo apavlo added the txns label May 1, 2018
@apavlo
Copy link
Member

apavlo commented May 1, 2018

Thank you for reporting this. We are having a lot of problems with our concurrency control scheme. Is this a blocker for your project?

@nwang57
Copy link
Contributor Author

nwang57 commented May 1, 2018

Yeah, we passed all the make check tests except the functions_test which is related to this problem. We will talk with @pmenon on Friday about this issue.

BTW, we just merged with catalog refactoring commit in the master with our changes. So far it doesn't break any test except the above one.

pmenon added a commit that referenced this issue May 2, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix for #1336
@pmenon
Copy link
Member

pmenon commented May 2, 2018

Fixed in #1337

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants