This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 624
RWSet performance fixes, LockFreeArray performance fixes and tests #1401
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a9847aa
Refactor of transaction_context to reduce lookups.
mbutrovich 96431ee
Change FindValid to Find in DataTable.
mbutrovich a8b1b0c
Try not to look up TileGroupHeader in Abort and Commit as much.
mbutrovich 76e0998
Change LockFreeArray::FindValid from O(n) to O(1).
mbutrovich e8e5de7
Refactor.
mbutrovich 58aa8c0
Lock_free_array refactor, documentation, and added more tests.
mbutrovich 344c914
Formatting.
mbutrovich 8afd1b7
Fix the last_tile_group_id optimization in TOTM.
mbutrovich 6779ba7
Fix RecordUpdate based on PR feedback.
mbutrovich 07d75b3
Formatting.
mbutrovich c37e6ef
PR feedback changes.
mbutrovich 2aed22b
More PR feedback changes.
mbutrovich ac0a760
Slight logic change in RecordUpdate.
mbutrovich ad0381d
Fix typo.
mbutrovich 2db074c
Added is_written_ flag back in for potential future optimizations.
mbutrovich d5583f0
Formatting.
mbutrovich 30fddc2
Merge branch 'master' into friday_night
tli2 21253c4
Merge branch 'master' into friday_night
tli2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have still two lookups here, one in line 99 and one in line 103. Is it even possible to do this with a single lookup? No, because some other thread could have changed the RW set between these to lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As best as I can tell, based on our current semantics we can't get away from two lookups on Read, or Delete.