Skip to content

Suppress validation errors from deprecated Google Symptoms signals #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2022
Merged

Suppress validation errors from deprecated Google Symptoms signals #1490

merged 2 commits into from
Jan 25, 2022

Conversation

nmdefries
Copy link
Contributor

Description

The validator still expects the old GS signals (ageusia_raw_search, etc) to be produced. When it doesn't find them, it fails, so tell it to ignore those checks.

Changelog

  • Production params
  • Local params

@nmdefries nmdefries requested a review from qx-teo January 25, 2022 20:14
@nmdefries nmdefries changed the title Suppress validation errors from deprecated Google Symptomts signals Suppress validation errors from deprecated Google Symptoms signals Jan 25, 2022
qx-teo
qx-teo approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@qx-teo qx-teo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@qx-teo
Copy link
Contributor

qx-teo commented Jan 25, 2022

This might (should) be fixed once the metadata updates itself btw

@nmdefries
Copy link
Contributor Author

Yeah, I expect so too, but it's not great for this to fail whenever we add new signals

@nmdefries nmdefries merged commit 5848368 into google_symptoms_omicron Jan 25, 2022
@nmdefries nmdefries deleted the suppress_checks_old_gs_signals branch January 25, 2022 20:19
@nmdefries nmdefries restored the suppress_checks_old_gs_signals branch January 26, 2022 14:20
@krivard krivard mentioned this pull request Jan 27, 2022
Merged
@nmdefries nmdefries deleted the suppress_checks_old_gs_signals branch February 18, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qx-teo qx-teo qx-teo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmdefries @qx-teo