[Backfill corrections] Fetch user-provided paths only at setup + increase pip timeout #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the backfill corrections check expected to fail? |
|
Whoops, didn't notice. The build was getting a 503 error from one of the package sites. Rerunning resolved it. |
|
This can be merged @krivard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that user-provided paths are saved permanently (evaluated only once) by using
make's:=assignment operator.Previously, these variables were assigned with
=which re-evaluates the expression every time the variable is used. Since we change the contents ofparams.json, at some points in theMakefile, the supposedly user-provided path variables actually contain the fixed dir names intended for use inside of the docker container.Bonus: increase
pip installtimeout from the default of 15 s. When building the docker container, installingdelphi-utilsand dependencies exceeds this, causing an error.Changelog
Fixes
Pipeline complained about not finding any relevant files in input dir, despite dir and files existing.