Skip to content

[Backfill corrections] Make sure pipeline has geo_value field to use #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2023
Merged

[Backfill corrections] Make sure pipeline has geo_value field to use #1761

merged 2 commits into from
Jan 17, 2023

Conversation

@nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jan 12, 2023 •
edited
Loading

Description

Rename fips field to geo_value -- downstream functions expect a field called geo_value. Modify validation check for lag and issue_date fields to require both to be present and values to be non-missing.

Changelog

  • utils.R
  • main.R
  • io.R
  • documentation files
  • NAMESPACE

@nmdefries nmdefries marked this pull request as ready for review January 13, 2023 15:24
@nmdefries nmdefries requested a review from jingjtang January 13, 2023 15:24
jingjtang
jingjtang approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmdefries
Copy link
Contributor Author

@krivard This is ready to merge

@krivard krivard merged commit 345b424 into main Jan 17, 2023
@krivard krivard deleted the ndefries/backfill/rename-fips branch January 17, 2023 22:23
@nmdefries nmdefries mentioned this pull request Jan 20, 2023
Closed
@krivard krivard mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingjtang jingjtang jingjtang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nmdefries @jingjtang @krivard