feat: unify linter settings across indicators and add incremental formatting #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
force-pushed
the
ds/lint
branch
3 times, most recently
from
9b6c484
to
98eaa3c
Compare
melange396
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
looks pretty good!
do you wanna make the same changes to the "template" files too?
- https://github.com/cmu-delphi/covidcast-indicators/blob/main/_template_python/.pylintrc
- https://github.com/cmu-delphi/covidcast-indicators/blob/main/_template_python/Makefile
- https://github.com/cmu-delphi/covidcast-indicators/blob/main/_template_python/setup.py
dshemetov
force-pushed
the
ds/lint
branch
5 times, most recently
from
b0d1c25
to
8e5a2b0
Compare
dshemetov
changed the title
dshemetov
force-pushed
the
ds/lint
branch
2 times, most recently
from
c24e3b0
to
46eb589
Compare
* all linters now use the same configuration file * add `make format` command to format all code * make sure all indicators pass with the new config * update the template files as well * add a new darker format job to CI * add python package caching * update README
|
This was approved a while ago, I'm just going to merge so the new pipeline code can benefit from these changes. |
|
looks like there were a lot of recent (force-pushed) changes since the old review... can you summarize them? |
|
Sure, I just
|
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to cmu-delphi/delphi-epidata#1328, unifying linting settings across indicators and these two repos.
Changelog
pyproject.tomlfor all indicators anddelphi_utils, removed all.pylintrc.pylintrc, instead of turning them into global rulessetup.pyfiles of each indicator while I was at it (ignored in git blame)make formatcommand to apply formatting to the changes on your current branch