build+ci: make local, gh, and Jenkins envs identical #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dmitry Shemetov <dshemetov@ucdavis.edu>
Co-authored-by: Dmitry Shemetov <dshemetov@ucdavis.edu>
* pandas[excel]<2 doesn't work, go back to xlrd and comment * add mock to changehc * add requests * remove setup.py from template
dshemetov
changed the base branch from
1973-clean-up-delphi-utils-take-2
to
main
dshemetov
force-pushed
the
ds/clean-clean-delphi-utils
branch
from
92ee419 to
cfb451b
Compare
* pin pip==23.0.1 everywhere * remove pip install calls from ci and deploy, make sure all dependencies are listed in pyproject.toml or setup.py and installed by the Makefile * remove wheel from dependencies, only needed wheel for bdist_wheel command, which setuptools>=70.1 provides
dshemetov
force-pushed
the
ds/clean-clean-delphi-utils
branch
from
983454b to
8a72ca0
Compare
dshemetov
changed the base branch from
main
to
1973-clean-up-delphi-utils-take-2
dshemetov
changed the title
|
need to add changes nhsn since nhsn was added in the new release |
aysim319
reviewed
Dec 17, 2024
| "Development Status :: 5 - Production/Stable", | ||
| "Intended Audience :: Developers", | ||
| "Programming Language :: Python :: 3.8", | ||
| "License :: MIT", |
There was a problem hiding this comment.
need to change this to "License :: OSI Approved :: MIT License"; fixing the merge conflict should fix this
aysim319
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I wonder if we should keep this... I know previously we wanted to convert all the setup.py into pyproject.toml, but I rememeber the release where we converted delphi_utils setup.py into pyproject.toml has some hiccups....
There was a problem hiding this comment.
I had some issues using the pyproject.toml for nhsn and ended up just using the setup.py. since this codebase will be replaced, I think it's better to keep setup.py and have it consistent with the other indicators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt to get our Python environments consistent across: local, Github CI, and Jenkins builds.
Changelog
make venvdid not upgrade pip. Jenkins pinned pip to 23.0.1. To make this consistent, CI now callsmake venvandmake venvinstalls pip==23.0.1.make install.pylintandpytestwere already listed in every indicator'ssetup.pyandpydocstylewas haphardly listed, so I removed the install command from CI, and addedpydocstyleto the rest of the indicators.pip install numpycommand since each indicator either explicitly lists it as a dependency or transitively through Pandas, so I removed that line.Associated Issue(s)