Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1972 replace covidcast #2056

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

1972 replace covidcast #2056

wants to merge 58 commits into from
+323 −7,606

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Sep 13, 2024 •
edited
Loading

Description

refactored covidcast that under the hood uses a for loop for each day to grab signals
(continuation of #2004) rebased main instead of merge failed badly and ended up closing itself

Changelog

Itemize code/test/documentation changes and files added/removed.

replaced instances of covidcast.signal and covidcast.metadata with respective epidata api calls

Associated Issue(s)

Addresses #1972
Addresses #1931
Addresses #1987

aysim319 and others added 25 commits July 25, 2024 10:53
@aysim319
in progress for replacing covidcast
4afe0f0
@aysim319
moving wrapper in seperate module
67a312c
@aysim319
working on test
e4f2679
@aysim319
post process for metadata
c941982
@aysim319
lint and cleanup
a5628ac
@aysim319
fixing for test
6e22db8
@aysim319
implimentating suggested changes
a2a149f
@aysim319
removing wrapper and directly converting in other places and moving t…
9269621 
…est as a script
@aysim319
modifing test
8e67b6c
@aysim319
more suggestion
bf21d33
@aysim319
sircomplainslot needs more filtering
d76cd40
@aysim319
adding credential for google symptoms
fd50d9d
@aysim319
mocking api call in google symptoms
76f1519
@aysim319
organizing validations
157c6c6
@aysim319
extended date range and throws error when comes empty
23384e7
@aysim319
delphi_utils/validator/datafetcher.py
e5c3b46
@dshemetov
test+refactor: tweak covidcast port tests and
33936a4 
rewrite the _parse_datetimes function to use
Pandas idioms
@dshemetov
fix: don't parse datetimes on unused columns
01a7f66
@dshemetov
lint: remove unused types
6eeef4e
@dshemetov
fix: dont import covidcast in sir_complainsalot
1f59e06
@dshemetov
fix: remove covidcast from indicator setup.py dependencies
7f60275
@dshemetov
fix: remove duplicate ported_signal
55150bc
@dshemetov
fix: revert _parse_datetimes
329d340
@aysim319
adding conditional to fail if api fails
9d91be7
@aysim319
change
5ac98ab
@aysim319 aysim319 mentioned this pull request Sep 13, 2024
Closed
@aysim319 aysim319 force-pushed the 1972-replace-covidcast branch from 9c9cd68 to b4039c5 Compare September 13, 2024 19:37
melange396
melange396 requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this -- i cant wait to see the end of the covidcast client!!!

This is a big change and i added a lot of comments. I highlighted a number of the comments that i think are particularly important by adding the "eyes" (👀) reaction to them.

_delphi_utils_python/delphi_utils/__init__.py Outdated Show resolved Hide resolved
testing_utils/metadata_output.txt Outdated Show resolved Hide resolved
_delphi_utils_python/delphi_utils/validator/datafetcher.py Outdated Show resolved Hide resolved
_delphi_utils_python/delphi_utils/validator/datafetcher.py Outdated Show resolved Hide resolved
_delphi_utils_python/delphi_utils/validator/datafetcher.py Outdated Show resolved Hide resolved
sir_complainsalot/delphi_sir_complainsalot/check_source.py Outdated Show resolved Hide resolved
sir_complainsalot/delphi_sir_complainsalot/check_source.py Outdated Show resolved Hide resolved
sir_complainsalot/delphi_sir_complainsalot/check_source.py Outdated Show resolved Hide resolved
testing_utils/delphi_utils/check_covidcast_port.py Outdated Show resolved Hide resolved
testing_utils/delphi_utils/requirements.txt Outdated Show resolved Hide resolved
@aysim319 aysim319 force-pushed the 1972-replace-covidcast branch from 43b8d29 to c355edb Compare September 20, 2024 18:50
@aysim319 aysim319 force-pushed the 1972-replace-covidcast branch from c355edb to fa9143a Compare September 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 requested changes

@dshemetov dshemetov Awaiting requested review from dshemetov

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aysim319 @melange396 @dshemetov