Skip to content

Conversation

jsharpna
Copy link
Contributor

Fixing issue #243 linter suggested removing argument since unused, but broke tests

@jsharpna jsharpna mentioned this pull request Aug 24, 2020
@krivard krivard requested a review from vishakha1812 August 24, 2020 18:07
@vishakha1812
Copy link
Contributor

geo tests are running fine but test_smooth.py is failing -> Detailed comment here
@krivard should I approve this PR in that case?

@krivard
Copy link
Contributor

krivard commented Aug 25, 2020

We'll wait for #243 to be resolved.

@dshemetov
Copy link
Contributor

Fixed smoother test. The key was this line in run.py, which didn't respect the indices of the dataframe.

@krivard
Copy link
Contributor

krivard commented Aug 26, 2020

James confirms tests pass

@vishakha1812
Copy link
Contributor

Tests pass.
Linter 10.0/10.
Approving!

vishakha1812
vishakha1812 previously approved these changes Aug 27, 2020
@krivard krivard changed the base branch from main to deploy-jhu August 27, 2020 18:48
@krivard krivard dismissed vishakha1812’s stale review August 27, 2020 18:48

The base branch was changed.

@krivard
Copy link
Contributor

krivard commented Aug 27, 2020

This seems very weird; @vishakha1812 ?

______________ ERROR at setup of TestRun.test_output_files_exist _______________

    @pytest.fixture(scope="session")
    def run_as_module():
        # Clean receiving directory
>       for fname in listdir("receiving"):
E       FileNotFoundError: [Errno 2] No such file or directory: 'receiving'

@vishakha1812
Copy link
Contributor

Saw that :/ Brian and I am looking into it.

@vishakha1812
Copy link
Contributor

This pipeline is error free. Approving..

@krivard krivard merged commit c012908 into deploy-jhu Aug 28, 2020
@krivard krivard deleted the jhu_fix_0824 branch August 28, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants