Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sir-complainsalot] Add grace period and dry run #287

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Sep 28, 2020

  • A method for sir-CAL to complain that's not blasting Slack, for testing purposes
  • The ability to tell sir-CAL not to bug anybody until results are N days late, for configurable N (currently global, might consider per-source or per-signal versions if we need them)

@krivard krivard requested a review from capnrefsmmat October 13, 2020 13:38
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure why you have grace instead of adding to the lag allowed for the sources in the params; just an easy way to change all of them at once?

@krivard
Copy link
Contributor Author

krivard commented Oct 13, 2020

That, but also to distinguish between when we usually expect a signal to become available, when it's nominally late but not worrisome, and when somebody should really take a look.

@krivard krivard merged commit cf6f4c1 into main Oct 13, 2020
@krivard krivard deleted the sir-dryrun branch October 29, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants