Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for public release #288

Merged
merged 8 commits into from
Sep 30, 2020
Merged

Prepare for public release #288

merged 8 commits into from
Sep 30, 2020

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Sep 29, 2020 •
edited
Loading

Draft PR for #284

  • DONE - MIT license (@capnrefsmmat what did you mean about putting a note in the README? our other repos don't include license information in the readme, and it's not part of the conditions of applying the license)
  • DONE - Revise README and maybe shuffle some stuff into a contributors' guide instead

@krivard krivard marked this pull request as draft September 29, 2020 20:02
@capnrefsmmat
Copy link
Contributor

https://github.com/cmu-delphi/www-covidcast does include the license in the README, and that also seems like a reasonable way to ensure contributors know they're MIT-licensing their contributions before they make a PR. But it can also go into a contribution guide

@krivard krivard mentioned this pull request Sep 29, 2020
Closed
5 tasks
capnrefsmmat
capnrefsmmat approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change

LICENSE Outdated Show resolved Hide resolved
@krivard @capnrefsmmat
Update LICENSE with correct copyright date
98b1992 
Co-authored-by: Alex Reinhart <alex@refsmmat.com>
@krivard krivard marked this pull request as ready for review September 30, 2020 13:19
@krivard krivard merged commit 9f0c228 into main Sep 30, 2020
@krivard krivard deleted the dev/public-release branch October 29, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capnrefsmmat capnrefsmmat capnrefsmmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krivard @capnrefsmmat @RoniRos @ryantibs