Refactor usafacts to use geo utils #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance with additional comments
chinandrew
reviewed
Oct 16, 2020
usafacts/tests/conftest.py
Outdated
Comment on lines
14
to
17
| for fname in listdir("../receiving"): | ||
| if fname[0] == ".": | ||
| continue | ||
| remove(join("../receiving", fname)) |
There was a problem hiding this comment.
I think this can be made into a one liner with
[remove(fname) for fname in glob.glob('receiving/*')]
There was a problem hiding this comment.
oops realized this is part of #314
chinandrew
reviewed
Oct 16, 2020
chinandrew
reviewed
Oct 16, 2020
safegraph/tests/test_process.py
Outdated
Comment on lines
132
to
133
| print(expected) | ||
| print(actual) |
There was a problem hiding this comment.
are these debug statements?
There was a problem hiding this comment.
Yes, removed sorry for having the multi sync workspace here.
chinandrew
reviewed
Oct 16, 2020
usafacts/delphi_usafacts/geo.py
Outdated
| df = df.copy().sort_values(["fips", "timestamp"]) | ||
| for col in COLS: | ||
| for col in cols: | ||
| # Get values from the aggregated county: | ||
| vals = df.loc[df["fips"] == pooled_fips, col].values / len(fips_list) |
There was a problem hiding this comment.
small nitpick, but would be good to standardize single vs double quotes within the file
Replace modular arithmetic with string suffix checking. Co-authored-by: chinandrew <chinandrew96@gmail.com>
chinandrew
approved these changes
Oct 16, 2020
|
Blocked on #325. |
|
Lgtm! |
|
I just realized there theres still static files that are used in USAFacts, sorry for missing in review. Figure we'll fix it when we add hhs + nation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The USAFacts indicator no longer uses localized libraries that have been superseded by
delphi_utils.GeoMapper.Fixes #338, which itself addresses part of #306. Synced to and #309 and #314, so should be submitted after them.