Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gap detector to Sir Complains-a-lot #327

Merged
merged 3 commits into from
Oct 19, 2020
Merged

Add a gap detector to Sir Complains-a-lot #327

merged 3 commits into from
Oct 19, 2020

Conversation

capnrefsmmat
Copy link
Contributor

Now complains if there is a gap in the reported data, e.g. if 2020-10-10 is missing but 2020-10-11 is present. This seems like it'd be very useful to have.

Also, add missing sources to the template.

Detects gaps in reported data, e.g. if just one day is missing but more
recent days are available.
@capnrefsmmat capnrefsmmat requested a review from krivard October 17, 2020 18:48
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xlnt

@capnrefsmmat
Copy link
Contributor Author

One note: it now takes like 9 minutes to run, because of all the API calls. But that will be much better when we figure out API streaming.

@krivard krivard merged commit 0783ebd into main Oct 19, 2020
@krivard krivard deleted the sir-gapdetector branch October 29, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants