Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add 7-day average of each signal to Safegraph indicator" #336

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Revert "Add 7-day average of each signal to Safegraph indicator" #336

merged 1 commit into from
Oct 20, 2020

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Oct 20, 2020

Reverts #309 to see if that fixes this error

@sgsmob
Copy link
Contributor

sgsmob commented Oct 20, 2020

Why are there so many files changed/deleted?

@krivard
Copy link
Contributor Author

krivard commented Oct 20, 2020

Because the deploy-* branch structure means that every time we merge a new feature into a deployment branch, it brings with it all the changes from main that were done to every other indicator since the last time deploy-safegraph was updated. It's a known problem with this workflow, currently a P1 in the fall OKR to ameliorate.

sgsmob
sgsmob approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@sgsmob sgsmob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard to reason about but looks ok

@krivard krivard merged commit 283e8c2 into deploy-safegraph Oct 20, 2020
@krivard krivard mentioned this pull request Oct 20, 2020
Closed
4 tasks
@krivard krivard deleted the revert-309-weekday branch October 29, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgsmob sgsmob sgsmob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krivard @sgsmob