Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wildcard imports from test #349

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Remove wildcard imports from test #349

merged 1 commit into from
Oct 21, 2020

Conversation

chinandrew
Copy link
Contributor

Closes #258 by removing remaining non emr_hosp (deactivated) wildcard imports.

Summary of changes

  • Remove wildcard imports
  • Remove an unused import

@chinandrew chinandrew requested a review from krivard October 21, 2020 17:44
@krivard
Copy link
Contributor

krivard commented Oct 21, 2020

This also removes from cdc covidnet -- was that intentional? it's probably fine since both are needed...

@chinandrew
Copy link
Contributor Author

This also removes from cdc covidnet -- was that intentional? it's probably fine since both are needed...

Yea since it was a one liner in a 3 line PR I just batched them 🙈

krivard
krivard approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xlnt

@krivard krivard merged commit 12aac02 into main Oct 21, 2020
@krivard krivard deleted the fix-test-imports branch October 29, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IMPROVEMENT: remove wildcard imports
2 participants
@chinandrew @krivard