JHU: Appease the linter #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
previously approved these changes
Oct 29, 2020
krivard
force-pushed
the
fix/deploy-jhu-linter
branch
from
e246208 to
beb5d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some linting errors that were introduced in #397 & #398 during the conflict resolution process (bad github; no biscuit)
@dshemetov I'm pretty sure the
rprefix in that regex inpull.pyis good but wanted to get your eyes on it. Because it's a network call, we don't have unit tests for it. I ran it by hand and it seemed to generate sensible output in thetimestampcolumn.