Skip to content

Fix linting for nchs #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2020
Merged

Fix linting for nchs #454

merged 3 commits into from
Nov 6, 2020

Conversation

chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Nov 6, 2020 •
edited
Loading

Gets pylint to pass

Summary of changes:

  • fix any small linting errors (naming, whitespace, etc)
  • ignore the larger lint errors that would require more refactoring (too many branches, etc)

krivard
krivard suggested changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid obfuscating linting exceptions

chinandrew and others added 2 commits November 6, 2020 13:02
@chinandrew @krivard
Update nchs_mortality/delphi_nchs_mortality/run.py
83d0337 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
@chinandrew @krivard
Update nchs_mortality/delphi_nchs_mortality/run.py
86a56b6 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
krivard
krivard approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit 7e9e6cb into main Nov 6, 2020
@krivard krivard deleted the nchs-list branch November 6, 2020 21:07
@chinandrew chinandrew mentioned this pull request Nov 9, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chinandrew @krivard