Fix smoother index drop #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have some conflicts here, but it's not on any files ostensibly edited by this PR so I don't really understand what's going on. |
|
That is strange. Any ideas for how to diagnose? |
|
Merge with/rebase onto main and see what happens? |
|
Ok that seemed to fix it? |
|
I think I can clean up this commit log, let me try rebasing these PRs I made last night. |
dshemetov
force-pushed
the
fix_smoother_index_drop
branch
from
521b0c7 to
6bfa9c1
Compare
|
Waaay cleaner now: 4 PRs, 4 commits. Thanks Katie, this was a nice learning experience! |
dshemetov
force-pushed
the
fix_smoother_index_drop
branch
from
6bfa9c1 to
647e05d
Compare
* entire array of nans is handled * left-padded nans are now ignored * a few other edge cases * add tests to match
dshemetov
force-pushed
the
fix_smoother_index_drop
branch
from
647e05d to
615105c
Compare
* restore the index after smoothing * test to match
dshemetov
force-pushed
the
fix_smoother_index_drop
branch
from
615105c to
ad01388
Compare
krivard
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the smoother would drop the index of the Pandas series given to it. The index is restored after smoothing. Base is #477 and contains #437, so should be merged after.