Skip to content

Get quidel to pass pylint and enable CI #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2020
Merged

Get quidel to pass pylint and enable CI #563

merged 2 commits into from
Nov 20, 2020

Conversation

chinandrew
Copy link
Contributor

Description

Fix outstanding pylint errors and enable the pylint check on CI. This does not make it pass pydocstyle yet.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Remove quidel from CI lint exclusion list
  • Fix linting errors on quidel

Fixes

@chinandrew chinandrew mentioned this pull request Nov 19, 2020
Closed
7 tasks
krivard
krivard approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit df57017 into main Nov 20, 2020
@krivard krivard deleted the quidelpylint branch November 20, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chinandrew @krivard