Skip to content

Add HRR and MSA to safegraph #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2020
Merged

Add HRR and MSA to safegraph #573

merged 2 commits into from
Nov 30, 2020

Conversation

chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Nov 23, 2020 •
edited
Loading

Description

Adding additional georesolutions to safegraph signal. See #114 for context.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Add HRR and MSA to constants file
  • Add conditional statements to map to HRR and MSA
  • Add HRR and MSA tests, and add a dimension check to existing tests since I had a typo where I was mapping to MSA instead of HRR and the HRR tests still passed with the original checks.

Fixes

@chinandrew chinandrew changed the title [DRAFT] Add HRR and MSA to safegraph Add HRR and MSA to safegraph Nov 24, 2020
@chinandrew chinandrew requested a review from sgsmob November 24, 2020 21:35
@krivard krivard merged commit a627e1c into main Nov 30, 2020
@krivard krivard deleted the safegraph-hrr-msa branch November 30, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgsmob sgsmob sgsmob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add MSA and HRR levels to SafeGraph data

3 participants

@chinandrew @sgsmob @krivard