Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove api.php from python client #1280

Closed
melange396 opened this issue Aug 24, 2023 · 2 comments
Closed

remove api.php from python client #1280

melange396 opened this issue Aug 24, 2023 · 2 comments
Labels
good first issue help wanted logs and monitoring logging, monitoring, alerting python client changes the Python client

Comments

@melange396
Copy link
Collaborator

modify the python client so it no longer uses the legacy "api.php" url.

the api.php endpoint uses some request variables differently than other endpoints do, which makes it difficult to do accurate aggregate analysis of webserver logs. the api.php endpoint also has a lower limit for the maximum number of rows returned; using appropriate endpoints directly instead will allow users to retrieve more rows in a single request.

this will require changing the BASE_URL in many of the integration tests which use the client (simple but tedious).

@melange396 melange396 added help wanted good first issue python client changes the Python client logs and monitoring logging, monitoring, alerting labels Aug 24, 2023
@melange396
Copy link
Collaborator Author

this will also necessitate changing the covidcast client at or around the same time.

@melange396
Copy link
Collaborator Author

duplicate of #1285

@melange396 melange396 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted logs and monitoring logging, monitoring, alerting python client changes the Python client
Projects
None yet
Development

No branches or pull requests

1 participant