Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add syntax feature documentation #1256

Merged
merged 5 commits into from
Aug 14, 2023
Merged

add syntax feature documentation #1256

merged 5 commits into from
Aug 14, 2023

Conversation

minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Aug 8, 2023

Closes #943

Screenshot 2023-08-10 at 4 15 00 PM Screenshot 2023-08-10 at 4 15 25 PM

@minhkhul minhkhul requested review from rzats and melange396 August 9, 2023 14:18
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not bad! in the "Example URLs" section, could you also show the equivalent of both examples that use these alternative parameters too?

docs/api/covidcast.md Outdated Show resolved Hide resolved
docs/api/covidcast.md Outdated Show resolved Hide resolved
minhkhul and others added 2 commits August 10, 2023 15:18
Co-authored-by: melange396 <george.haff@gmail.com>
@minhkhul minhkhul requested a review from melange396 August 10, 2023 20:14
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple grammar things

docs/api/covidcast.md Outdated Show resolved Hide resolved
docs/api/covidcast.md Outdated Show resolved Hide resolved
minhkhul and others added 2 commits August 14, 2023 12:34
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: melange396 <george.haff@gmail.com>
@minhkhul minhkhul requested a review from melange396 August 14, 2023 16:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melange396 melange396 merged commit c199403 into dev Aug 14, 2023
@melange396 melange396 deleted the document_syntax_feature branch August 14, 2023 16:58
melange396 added a commit that referenced this pull request Aug 17, 2023
* Performance testing testing workflow (#1253)

* New CTIS publication (#1255)

* Newer CTIS publication

* bring loggers in sync and add multiproc capabilities (#1254)

* add syntax feature documentation (#1256)

* Newest CTIS publication

* chore: sync to www-covidcast release v3.2.7

* moving quidel signals to non-public access (#1261)

with integration tests!

---------

Co-authored-by: Dmytro Trotsko <dmytrotsko@gmail.com>

* chore: release delphi-epidata 4.1.8

---------

Co-authored-by: Dmytro Trotsko <dmytrotsko@gmail.com>
Co-authored-by: Rostyslav Zatserkovnyi <zatserkovnyi.rostyslav@gmail.com>
Co-authored-by: Alex Reinhart <areinhar@stat.cmu.edu>
Co-authored-by: nmdefries <42820733+nmdefries@users.noreply.github.com>
Co-authored-by: melange396 <george.haff@gmail.com>
Co-authored-by: minhkhul <118945681+minhkhul@users.noreply.github.com>
Co-authored-by: minhkhul <minhkhul@users.noreply.github.com>
Co-authored-by: melange396 <melange396@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new syntax features for covidcast endpoint
2 participants