Fix week parsing for date parameters/arguments #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
@melange396 thx for fixing that. I didn't even know that we have such |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #1284 broke some week and week range parsing and was noticed in cmu-delphi/covidcast-indicators#1904.
Heres evidence of the new test failing before i applied the fix:
https://github.com/cmu-delphi/delphi-epidata/actions/runs/6564148018/job/17829935532
This solution is a bit brittle, but ~all of
_params.pyis a mess and needs to be cleaned up, so i think this can fly for now.