Skip to content

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jun 17, 2021

for releasing to pypi and npm + sync dev/main

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

add a release helper workflow (pipeline) similar to www-main and others. steps taken

  • use release-drafter (like www-main) to create release notes and git tag
  • publish epidata client to PyPi -> requires PYPI_API_TOKEN secret
  • publish epidata JS client to NPM -> requires NPM_TOKEN secret -> do we have an account?
  • create a PR that merges the main back to dev

In addition, small tunings for the definition of the Epidata JS client

for releasing to pypi and npm + sync dev/main
@sgratzl sgratzl added the chore label Jun 17, 2021
@sgratzl sgratzl requested a review from krivard June 17, 2021 07:09
@sgratzl sgratzl self-assigned this Jun 17, 2021
@sgratzl
Copy link
Member Author

sgratzl commented Jun 17, 2021

if we want better release-notes we could add more labels to Pull Requests, e.g. we could separate between:

  • server
  • acquisition
  • python client
  • Javascript client
  • R client
  • documentation
  • chore

@krivard
Copy link
Contributor

krivard commented Jun 17, 2021

@korlaxxalrok I added the delphi-epidata PyPI token to LastPass. Would you add that to the env secrets, and work with @christymelucci to set us up with NPM?

@korlaxxalrok
Copy link
Contributor

@krivard Yup, will do. PYPI tokens have been added to org secrets.

@korlaxxalrok
Copy link
Contributor

@sgratzl DELPHI_NPM_TOKEN token is added to org secrets.

krivard
krivard previously approved these changes Jun 21, 2021
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go once conflicts are resolved

@sgratzl
Copy link
Member Author

sgratzl commented Jun 22, 2021

good to go once conflicts are resolved

resolved

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit 81951e0 into dev Jun 22, 2021
@krivard krivard deleted the sgratzl/release_helper branch June 22, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants