Skip to content

documentation for google symptoms new signals #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 21, 2022
Merged

documentation for google symptoms new signals #815

merged 9 commits into from
Jan 21, 2022

Conversation

@nloliveira
Copy link
Contributor

closes

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Updated documentation for Google symptoms signals.

@nloliveira nloliveira requested a review from krivard January 20, 2022 22:37
krivard
krivard suggested changes Jan 21, 2022
View reviewed changes
docs/api/covidcast-signals/google-symptoms.md Outdated
popularity of symptoms in searches within each geographical region individually.
This means that the resulting values of symptom popularity are **NOT**
comparable across geographic regions.
comparable across geographic regions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe mention comparing different signals within a region here again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

nloliveira and others added 7 commits January 21, 2022 11:02
@nloliveira @krivard
Update docs/api/covidcast-signals/google-symptoms.md
085ab52 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
@nloliveira @krivard
Update docs/api/covidcast-signals/google-symptoms.md
a505cb2 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
@nloliveira @krivard
Update docs/api/covidcast-signals/google-symptoms.md
4347694 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
@nloliveira @krivard
Update docs/api/covidcast-signals/google-symptoms.md
789e8e1 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
@nloliveira @krivard
Update docs/api/covidcast-signals/google-symptoms.md
da547fd 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
@nloliveira @krivard
Update docs/api/covidcast-signals/google-symptoms.md
662b2f2 
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
emphasizing when signals are comparable and when they are not
0d15c83
@nloliveira nloliveira requested a review from krivard January 21, 2022 16:46
krivard
krivard approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit d345b57 into dev Jan 21, 2022
@krivard krivard deleted the doc_google_symptoms_omicron branch January 21, 2022 17:32
@krivard krivard mentioned this pull request Jan 28, 2022
Merged
@melange396 melange396 mentioned this pull request Jun 24, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nloliveira @krivard