Skip to content

Allow "*" as a timeset, update roxygen, tests #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

Allow "*" as a timeset, update roxygen, tests #101

merged 1 commit into from
May 10, 2023

Conversation

@brookslogan
Copy link
Contributor

@brookslogan brookslogan commented May 10, 2023

Closes #100.

@brookslogan brookslogan requested a review from dshemetov May 10, 2023 13:14
@brookslogan brookslogan requested a review from dajmcdon as a code owner May 10, 2023 13:14
dshemetov
dshemetov approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great catch on this, thanks Logan!

@dshemetov dshemetov merged commit 02a6882 into dev May 10, 2023
@dshemetov dshemetov deleted the lcb/allow-timeset-star-again branch May 10, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dshemetov dshemetov dshemetov approved these changes

@dajmcdon dajmcdon Awaiting requested review from dajmcdon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parse_timeset_input should allow "*"

4 participants

@brookslogan @dshemetov @lcbrooks