-
Notifications
You must be signed in to change notification settings - Fork 10
min_train_window
, quantile_by_key
args are not used
#169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some thoughts on naming things here and how they should function. Naming:
Functionality:
|
This also ties into discussions about alternative interpretations of |
The min training window would also be useful as a step, or as part of |
A potential bigger tradeoff we're taking with a |
And another trade-off: it'll be harder to get |
|
Grepping around, @dshemetov and I were unable to see
min_train_window
orquantile_by_key
actually used byarx_forecaster
,arx_classifier
,flatline_forecaster
, or any other forecaster I missed. We did find:min_train_window
part; see comment here.quantile_by_key
docs referencelayer_residual_quantiles()
'by_key
parameter, but I can't see it actually being forwarded along.The text was updated successfully, but these errors were encountered: