Skip to content

Update cdc_baseline_forecaster to handle 0 in aheads, default to aheads = 1:4 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #318
brookslogan opened this issue Nov 14, 2023 · 2 comments
Open
Tracked by #318
Assignees

Comments

@brookslogan
Copy link
Contributor

In order to reproduce & make default the changes made Nov 1 here + enable simplification of this baseline generation script.

@brookslogan brookslogan self-assigned this Nov 14, 2023
@dajmcdon
Copy link
Contributor

@brookslogan To be clear, is the only change that aheads = 1:4 rather than 1:5? nsims ==1e5 already. I'm going to add this to #271 (will come with a version bump to 0.0.7).

@dajmcdon
Copy link
Contributor

Other notes:

  • location_to_abbr() function in the script is in epipredict but not exported.
  • Any suggestions for how to automatically handle the forecast_date / reference_date mismatch?
  • The formatting beginning on line 231, can any of that be added to the *_formatter()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants