-
Notifications
You must be signed in to change notification settings - Fork 10
simplify grab_residuals #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, it returns NULL
if there aren't residuals? that does make this way easier. I'm assuming there's at least one non-regression model calling grab_residuals somewhere in the tests?
I kind of doubt that there is a test where a classifier calls this function. Are you thinking that there needs to be? |
Can we bump minor/patch version and add a note to CHANGELOG? |
@dshemetov Sure, though I'm unfamiliar. What would you like to bump to? 0.0.7 or 0.0.6001? Something else? |
0.0.7 sounds good to me. |
This might do it for you (haven't tried). |
er, I was actually thinking was a model for which |
residuals are just the difference between the training response and the point prediction in-sample (at least the kind we're using here), so would be mathematically defined for any regression engine (including quantile regression). This should fail if the engine is a classifier though. |
closes #270 .