Skip to content

simplify grab_residuals #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2023
Merged

simplify grab_residuals #271

merged 4 commits into from
Dec 20, 2023

Conversation

dajmcdon
Copy link
Contributor

closes #270 .

@dajmcdon dajmcdon requested a review from dsweber2 November 29, 2023 02:07
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it returns NULL if there aren't residuals? that does make this way easier. I'm assuming there's at least one non-regression model calling grab_residuals somewhere in the tests?

@dajmcdon
Copy link
Contributor Author

I kind of doubt that there is a test where a classifier calls this function. Are you thinking that there needs to be?

@dajmcdon dajmcdon requested a review from dsweber2 November 29, 2023 20:20
@dshemetov
Copy link
Contributor

Can we bump minor/patch version and add a note to CHANGELOG?

@dajmcdon
Copy link
Contributor Author

@dshemetov Sure, though I'm unfamiliar. What would you like to bump to? 0.0.7 or 0.0.6001? Something else?

@dshemetov
Copy link
Contributor

0.0.7 sounds good to me.

@dshemetov
Copy link
Contributor

This might do it for you (haven't tried).

@dsweber2
Copy link
Contributor

er, I was actually thinking was a model for which stats:residuals isn't defined (is it for quant_reg, for example?). Totally wrote the wrong thing sorry.

@dajmcdon
Copy link
Contributor Author

dajmcdon commented Nov 29, 2023

residuals are just the difference between the training response and the point prediction in-sample (at least the kind we're using here), so would be mathematically defined for any regression engine (including quantile regression). This should fail if the engine is a classifier though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking whether grab_residuals method exists eating up unreasonable amounts of time
3 participants