Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth qr vignette #314

Merged
merged 28 commits into from
Apr 27, 2024
Merged

Smooth qr vignette #314

merged 28 commits into from
Apr 27, 2024

Conversation

rachlobay
Copy link
Contributor

This branch has the smooth qr vignette. I removed the lower and upper miscoverage rate stuff.

@rachlobay rachlobay requested a review from dajmcdon as a code owner April 8, 2024 21:11
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the top part. This is where you were going to use WIS right?

@dajmcdon dajmcdon mentioned this pull request Apr 12, 2024
18 tasks
@rachlobay
Copy link
Contributor Author

Yes. This is the vignette where I am going to try add a bit about WIS to. TBD.

Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this into articles/ since it takes a long while to run.

The rest of my comments are minor. Looks good!!

Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one.

rachlobay and others added 15 commits April 27, 2024 00:16
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
Co-authored-by: Daniel McDonald <dajmcdon@gmail.com>
@rachlobay rachlobay merged commit e20ae32 into dev Apr 27, 2024
3 checks passed
@dajmcdon dajmcdon deleted the vignette-smooth-qr branch September 20, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants