New hardhat quantiles #442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* missing rlang prefix * max(NULL, date) produces an integer, tests fail
Merge branch 'dev' into 330-epi_recipe # Conflicts: # DESCRIPTION # NAMESPACE # R/autoplot.R # R/epi_keys.R # R/epi_recipe.R # R/layer_add_forecast_date.R # R/layer_add_target_date.R # R/layer_cdc_flatline_quantiles.R # R/layer_threshold_preds.R # R/layers.R # R/reexports-tidymodels.R # R/step_training_window.R # man/autoplot-epipred.Rd # man/layer_add_forecast_date.Rd # man/layer_add_target_date.Rd # man/layer_cdc_flatline_quantiles.Rd # man/layer_threshold.Rd # man/recipe.epi_df.Rd # man/reexports.Rd # man/step_training_window.Rd # man/update.layer.Rd # tests/testthat/test-key_colnames.R # tests/testthat/test-population_scaling.R # vignettes/update.Rmd
Deprecate `epi_recipe()` in favour of `recipe()`
update action versions
Merge commit 'b74c039' into new-hardhat-quantiles # Conflicts: # DESCRIPTION # NAMESPACE # R/arx_forecaster.R # R/autoplot.R # R/cdc_baseline_forecaster.R # R/dist_quantiles.R # R/epi_recipe.R # R/epi_workflow.R # R/frosting.R # R/get_test_data.R # R/layer_cdc_flatline_quantiles.R # R/step_epi_naomit.R # R/step_epi_shift.R # R/step_epi_slide.R # R/step_growth_rate.R # R/step_lag_difference.R # _pkgdown.yml # man/cdc_baseline_forecaster.Rd # man/frosting.Rd # man/get_test_data.Rd # man/layer_cdc_flatline_quantiles.Rd # man/predict-epi_workflow.Rd # man/recipe.epi_df.Rd # man/step_epi_naomit.Rd # man/step_epi_shift.Rd # man/step_epi_slide.Rd # man/step_growth_rate.Rd # man/step_lag_difference.Rd # tests/testthat/test-check_enough_train_data.R # tests/testthat/test-dist_quantiles.R # tests/testthat/test-epi_recipe.R # tests/testthat/test-epi_workflow.R # tests/testthat/test-get_test_data.R # tests/testthat/test-key_colnames.R # tests/testthat/test-layer_add_forecast_date.R # tests/testthat/test-step_epi_shift.R # tests/testthat/test-step_epi_slide.R # tests/testthat/test-step_training_window.R # vignettes/preprocessing-and-models.Rmd
|
Something's wrong with the diff above. It shouldn't have some of these commits. |
|
it has #370 and #394 in there, so i think you branched off dev...v0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
dajmcdon.
DESCRIPTIONandNEWS.md.Always increment the patch version number (the third number), unless you are
making a release PR from dev to main, in which case increment the minor
version number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
0.7.2, then write your changes under the 0.8 heading).
Change explanations for reviewer
This PR replaces
dist_quantiles(), a custom distribution related to thedistributionalpackage, withquantile_pred()from thehardhatpackage. This is one step in off-loading some custom components to coretidymodelsfunctionality.